Skip to contentSkip to conversation

soundwire: bus: filter out more -EDATA errors on clock stop

PATCH Applied Bard Liao 2 participants 2 messages Jul 14, 2021 – Jul 22, 2021 SoundWire

lore
Share & tools
lore

Bard Liao

author maintainer
#0 lore raw

PATCH 1/1 soundwire: bus: filter out more -EDATA errors on clock stop

From: Pierre-Louis Bossart <[email protected]>

We've added quite a few filters to avoid throwing errors if a Device does not respond to commands during the clock stop sequences, but we missed one.

This will lead to an isolated message

[ 6115.294412] soundwire sdw-master-1: SDW_SCP_STAT bread failed:-61

The callers already filter this error code, so there's no point in keeping it at the lower level.

Since this is a recoverable error, make this dev_err() conditional and only log cases with Command Failed.

---
 drivers/soundwire/bus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soundwire/bus.c +2 -1
index 3e6d4addac2f..278a4fbdb88d 100644
@@ -896,7 +896,8 @@ static int sdw_bus_wait_for_clk_prep_deprep(struct sdw_bus *bus, u16 dev_num)
 	do {
 		val = sdw_bread_no_pm(bus, dev_num, SDW_SCP_STAT);
 		if (val < 0) {
-			dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val);
+			if (val != -ENODATA)
+				dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val);
 			return val;
 		}
 		val &= SDW_SCP_STAT_CLK_STP_NF;
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Bard Liao

From: Pierre-Louis Bossart <[email protected]>

We've added quite a few filters to avoid throwing errors if a Device does not respond to commands during the clock stop sequences, but we missed one.

Quoted 8 lines

This will lead to an isolated message

[ 6115.294412] soundwire sdw-master-1: SDW_SCP_STAT bread failed:-61

The callers already filter this error code, so there's no point in keeping it at the lower level.

Since this is a recoverable error, make this dev_err() conditional and only log cases with Command Failed.

Applied, thanks

Signature · 1 line
~Vinod