Skip to contentSkip to conversation

tools: PCI: Zero-initialize param

PATCH Applied Shunyong Yang 3 participants 4 messages Jul 14, 2021 – Aug 5, 2021 PCI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools: PCI: Zero-initialize param

The values in param may be random if they are not initialized, which may cause use_dma flag set even when "-d" option is not provided in command line. Initializing all members to 0 to solve this.

---
v2: Change {0} to {} as Leon Romanovsky's comment.

---
 tools/pci/pcitest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/pci/pcitest.c +1 -1
index 0a1344c45213..441b54234635 100644
@@ -40,7 +40,7 @@ struct pci_test {
 
 static int run_test(struct pci_test *test)
 {
-	struct pci_endpoint_test_xfer_param param;
+	struct pci_endpoint_test_xfer_param param = {};
 	int ret = -EINVAL;
 	int fd;
 
Signature · 1 line
2.25.1
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Shunyong Yang

The values in param may be random if they are not initialized, which may cause use_dma flag set even when "-d" option is not provided in command line. Initializing all members to 0 to solve this.

Thanks for the fix.

Quoted 20 lines

---
v2: Change {0} to {} as Leon Romanovsky's comment.

---
 tools/pci/pcitest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/pci/pcitest.c +1 -1
index 0a1344c45213..441b54234635 100644
@@ -40,7 +40,7 @@ struct pci_test {
 
 static int run_test(struct pci_test *test)
 {
-	struct pci_endpoint_test_xfer_param param;
+	struct pci_endpoint_test_xfer_param param = {};
 	int ret = -EINVAL;
 	int fd;
 
#2 lore raw

Hi, Bjorn,

   Would you please help to review and put this tiny fix (for tools/pci/pcitest.c) in your merge queue? Kishon has acked.

Thanks.

Shunyong

Quoted 32 lines · Kishon Vijay Abraham I
Quoted 5 lines · Shunyong Yang

The values in param may be random if they are not initialized, which may cause use_dma flag set even when "-d" option is not provided in command line. Initializing all members to 0 to solve this.

Thanks for the fix.

Quoted 20 lines

---
v2: Change {0} to {} as Leon Romanovsky's comment.

---
  tools/pci/pcitest.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/pci/pcitest.c +1 -1
index 0a1344c45213..441b54234635 100644
@@ -40,7 +40,7 @@ struct pci_test {
 
  static int run_test(struct pci_test *test)
  {
-	struct pci_endpoint_test_xfer_param param;
+	struct pci_endpoint_test_xfer_param param = {};
  	int ret = -EINVAL;
  	int fd;