Skip to contentSkip to conversation

drm/mipi: set fwnode when a mipi_dsi_device is registered

PATCH In review Will McVicker 1 participant 2 messages Jul 17, 2021 – Aug 31, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/mipi: set fwnode when a mipi_dsi_device is registered

This allows the fw_devlink feature to work across mipi_dsi bus devices too. This feature avoids unnecessary probe deferrals of mipi_dsi devices, defers consumers of mipi_dsi devices till the mipi_dsi devices probe, and allows mipi_dsi drivers to implement sync_state() callbacks.

---
 drivers/gpu/drm/drm_mipi_dsi.c | 1 +
 1 file changed, 1 insertion(+)

v2:
Thanks Saravana for the comments! I updated the commit message and added your reviewed-by.

drivers/gpu/drm/drm_mipi_dsi.c +1 -0
index 5dd475e82995..469d56cf2a50 100644
@@ -222,6 +222,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
 	}
 
 	dsi->dev.of_node = info->node;
+	dsi->dev.fwnode = of_fwnode_handle(info->node);
 	dsi->channel = info->channel;
 	strlcpy(dsi->name, info->type, sizeof(dsi->name));
 
Signature · 1 line
2.32.0.402.g57bb445576-goog
#1 lore raw

Hi All,

I'd like to send a reminder for a review on this patch.

Thanks,
Will

Quoted 32 lines · Will McVicker

This allows the fw_devlink feature to work across mipi_dsi bus devices too. This feature avoids unnecessary probe deferrals of mipi_dsi devices, defers consumers of mipi_dsi devices till the mipi_dsi devices probe, and allows mipi_dsi drivers to implement sync_state() callbacks.

---
 drivers/gpu/drm/drm_mipi_dsi.c | 1 +
 1 file changed, 1 insertion(+)

v2:
Thanks Saravana for the comments! I updated the commit message and added your reviewed-by.

drivers/gpu/drm/drm_mipi_dsi.c +1 -1
index 5dd475e82995..469d56cf2a50 100644
@@ -222,6 +222,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
        }
 
        dsi->dev.of_node = info->node;
+       dsi->dev.fwnode = of_fwnode_handle(info->node);
        dsi->channel = info->channel;
        strlcpy(dsi->name, info->type, sizeof(dsi->name));
 
--

2.32.0.402.g57bb445576-goog