Skip to contentSkip to conversation

Implement the BST allocator

PATCH Superseded Andrzej Turko 2 participants 7 messages Jul 20, 2021

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Implement the BST allocator

This patch series implements an allocator with best-fit strategy. This implementation is based on a balanced search tree which allows for fast lookup of free blocks.

Cc Zbigniew Kempczyński <[email protected]>

Andrzej Turko (4):
lib/intel_allocator: Fix argument names in declarations lib/igt_bst: Add a BST interface and an AVL implementation lib/intel_allocator_bst: Implement the allocator with a BST tests/i915_api_intel_allocator: Add the BST allocator

 lib/igt_bst.c                    | 157 ++++++++
 lib/igt_bst.h                    |  69 ++++
 lib/igt_bst_avl.c                | 651 ++++++++++++++++++++++++++++++
 lib/intel_allocator.c            |   7 +
 lib/intel_allocator.h            |   9 +-
 lib/intel_allocator_bst.c        | 672 +++++++++++++++++++++++++++++++
 lib/meson.build                  |   3 +
 tests/i915/api_intel_allocator.c |  55 ++-
 8 files changed, 1599 insertions(+), 24 deletions(-)
 create mode 100644 lib/igt_bst.c
 create mode 100644 lib/igt_bst.h
 create mode 100644 lib/igt_bst_avl.c
 create mode 100644 lib/intel_allocator_bst.c
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 1/4 lib/intel_allocator: Fix argument names in declarations

Unify the argument names to avoid confusion.

Cc Zbigniew Kempczyński <[email protected]>
---
 lib/intel_allocator.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
lib/intel_allocator.h +4 -4
index c14f57b4d..7d9d01123 100644
@@ -144,13 +144,13 @@ struct intel_allocator {
 			  uint64_t size, uint64_t alignment,
 			  enum allocator_strategy strategy);
 	bool (*is_allocated)(struct intel_allocator *ial, uint32_t handle,
-			     uint64_t size, uint64_t alignment);
+			     uint64_t size, uint64_t offset);
 	bool (*reserve)(struct intel_allocator *ial,
-			uint32_t handle, uint64_t start, uint64_t size);
+			uint32_t handle, uint64_t start, uint64_t end);
 	bool (*unreserve)(struct intel_allocator *ial,
-			  uint32_t handle, uint64_t start, uint64_t size);
+			  uint32_t handle, uint64_t start, uint64_t end);
 	bool (*is_reserved)(struct intel_allocator *ial,
-			    uint64_t start, uint64_t size);
+			    uint64_t start, uint64_t end);
 	bool (*free)(struct intel_allocator *ial, uint32_t handle);
 
 	void (*destroy)(struct intel_allocator *ial);
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

PATCH 2/4 lib/igt_bst: Add a BST interface and an AVL implementation

In reply to Andrzej Turko

This adds an efficient binary search tree implementation in order to support an allocator with best-fit strategy.

Cc Zbigniew Kempczyński <[email protected]>
---
 lib/igt_bst.c     | 157 +++++++++++
 lib/igt_bst.h     |  69 +++++
 lib/igt_bst_avl.c | 651 ++++++++++++++++++++++++++++++++++++++++++++++
 lib/meson.build   |   2 +
 4 files changed, 879 insertions(+)
 create mode 100644 lib/igt_bst.c
 create mode 100644 lib/igt_bst.h
 create mode 100644 lib/igt_bst_avl.c
lib/igt_bst.c new file +157 -0
new file mode 100644
index 000000000..a24859213
@@ -0,0 +1,157 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2021 Intel Corporation
+ */
+
+#include "igt_bst.h"
+
+
+/**
+ * igt_bst_insert
+ * @bst: igt_bst pointer
+ * @value: a pointer value being inserted
+ * @key: the key under which the value should be stored
+ *
+ * Inserts a new value to the bst.
+ *
+ * Returns: a pointer to the newly created node.
+ */
+void *igt_bst_insert(struct igt_bst *bst, void *value, uint64_t key)
+{
+	return bst->insert(bst, value, key);
+}
+
+/**
+ * igt_bst_erase
+ * @bst: igt_bst pointer
+ * @nodeptr: a pointer to a node in the bst
+ *
+ * Erases the indicated node.
+ *
+ * Returns: the value associated with the
+ * erased node.
+ */
+void *igt_bst_erase(struct igt_bst *bst, void *nodeptr)
+{
+	return bst->erase(bst, nodeptr);
+}
+
+/**
+ * igt_bst_query_successor
+ * @bst: igt_bst pointer
+ * @key: an arbitrary key
+ *
+ * Among the elements currently present in the bst,
+ * finds the one with the smallest key not smaller than
+ * the given key.
+ *
+ * Returns: a value associated with the found element,
+ * NULL if all keys in the tree are smaller than the key
+ * parameter.
+ */
+void *igt_bst_query_successor(struct igt_bst *bst, uint64_t key)
+{
+	return bst->query_successor(bst, key);
+}
+
+/**
+ * igt_bst_query_successor
+ * Similar to igt_bst_query_predecessor, but looks for an
+ * element with the greatest key not exceeding the parameter.
+ */
+void *igt_bst_query_predecessor(struct igt_bst *bst, uint64_t key)
+{
+	return bst->query_predecessor(bst, key);
+}
+
+/**
+ * igt_bst_pop_successor
+ * Like igt_bst_query_successor, but also removes the
+ * found element from the bst.
+ */
+void *igt_bst_pop_successor(struct igt_bst *bst, uint64_t key)
+{
+	return bst->pop_successor(bst, key);
+}
+
+/**
+ * igt_bst_pop_predecessor
+ * Like igt_bst_query_predecessor, but also removes the
+ * found element from the bst.
+ */
+void *igt_bst_pop_predecessor(struct igt_bst *bst, uint64_t key)
+{
+	return bst->pop_predecessor(bst, key);
+}
+
+/* check whether the bst contains any elements */
+bool igt_bst_empty(struct igt_bst *bst)
+{
+	return bst->bst_empty(bst);
+}
+
+/* retrieve the value from the element in the bst given by the pointer to its node */
+void *igt_bst_get_value(struct igt_bst *bst, void *nodeptr)
+{
+	return bst->get_value(nodeptr);
+}
+
+/* retrieve the key from the element the bst given by the pointer to its node */
+uint64_t igt_bst_get_key(struct igt_bst *bst, void *nodeptr)
+{
+	return bst->get_key(nodeptr);
+}
+
+/**
+ * igt_bst_leftmost_entry
+ * @bst: igt_bst pointer
+ *
+ * Finds an element in the bst with the smallest key.
+ *
+ * Returns: a pointer to the found node,
+ * NULL if the bst is empty.
+ */
+void *igt_bst_leftmost_entry(struct igt_bst *bst)
+{
+	return bst->leftmost_entry(bst);
+}
+
+/**
+ * igt_bst_rightmost_entry
+ * See igt_bst_leftmost_entry.
+ */
+void *igt_bst_rightmost_entry(struct igt_bst *bst)
+{
+	return bst->rightmost_entry(bst);
+}
+
+/**
+ * igt_bst_next_entry
+ * @bst: igt_bst pointer
+ * @nodeptr: a pointer to a node in the bst
+ *
+ * Finds the next element in the bst in the
+ * nondecreasing order of keys.
+ * Can be used to iterate over all elements.
+ *
+ * Retuns: a pointer to the next node in the bst,
+ * NULL if nodeptr points to the last node.
+ */
+void *igt_bst_next_entry(struct igt_bst *bst, void *nodeptr)
+{
+	return bst->next_entry(nodeptr);
+}
+
+/**
+ * igt_bst_prev_entry
+ * Like igt_bst_next_entry, but returns the previous node.
+ */
+void *igt_bst_prev_entry(struct igt_bst *bst, void *nodeptr)
+{
+	return bst->prev_entry(nodeptr);
+}
+
+void igt_bst_free(struct igt_bst *bst)
+{
+	bst->bst_free(bst);
+}
lib/igt_bst.h new file +69 -0

69 lines not on this page · raw message

lib/igt_bst_avl.c new file +651 -0

651 lines not on this page · raw message

lib/meson.build +2 -0
index 67d405129..a1aa0ee12 100644
@@ -11,6 +11,8 @@ lib_sources = [
 	'i915/gem_mman.c',
 	'i915/gem_vm.c',
 	'i915/intel_memory_region.c',
+	'igt_bst.c',
+	'igt_bst_avl.c',
 	'igt_collection.c',
 	'igt_color_encoding.c',
 	'igt_debugfs.c',
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#3 lore raw

PATCH 3/4 lib/intel_allocator_bst: Implement the allocator with a BST

In reply to Andrzej Turko

This implements an alternative to the simple allocator. The BST allocator follows best-fit strategy in order to use the address space more effectively.
The use of a binary search tree speeds up finding free blocks of memory (compared to a list).

Cc Zbigniew Kempczyński <[email protected]>
---
 lib/intel_allocator.c     |   7 +
 lib/intel_allocator.h     |   1 +
 lib/intel_allocator_bst.c | 672 ++++++++++++++++++++++++++++++++++++++
 lib/meson.build           |   1 +
 4 files changed, 681 insertions(+)
 create mode 100644 lib/intel_allocator_bst.c
lib/intel_allocator.c +7 -0
index 133176ed4..2ef487a05 100644
@@ -71,6 +71,9 @@ intel_allocator_random_create(int fd, uint64_t start, uint64_t end);
 struct intel_allocator *
 intel_allocator_simple_create(int fd, uint64_t start, uint64_t end,
 			      enum allocator_strategy strategy);
+struct intel_allocator *
+intel_allocator_bst_create(int fd, uint64_t start, uint64_t end,
+			   enum allocator_strategy strategy);
 
 /*
  * Instead of trying to find first empty handle just get new one. Assuming
@@ -311,6 +314,10 @@ static struct intel_allocator *intel_allocator_create(int fd,
 		ial = intel_allocator_simple_create(fd, start, end,
 						    allocator_strategy);
 		break;
+	case INTEL_ALLOCATOR_BST:
+		ial = intel_allocator_bst_create(fd, start, end,
+						 allocator_strategy);
+		break;
 	default:
 		igt_assert_f(ial, "Allocator type %d not implemented\n",
 			     allocator_type);
lib/intel_allocator.h +1 -0
index 7d9d01123..93ecbc3e4 100644
@@ -211,6 +211,7 @@ void intel_allocator_print(uint64_t allocator_handle);
 #define INTEL_ALLOCATOR_RELOC  1
 #define INTEL_ALLOCATOR_RANDOM 2
 #define INTEL_ALLOCATOR_SIMPLE 3
+#define INTEL_ALLOCATOR_BST    4
 
 #define GEN8_GTT_ADDRESS_WIDTH 48
 
lib/intel_allocator_bst.c new file +672 -0

672 lines not on this page · raw message

lib/meson.build +1 -0
index a1aa0ee12..62c8dbf20 100644
@@ -38,6 +38,7 @@ lib_sources = [
 	'igt_x86.c',
 	'instdone.c',
 	'intel_allocator.c',
+	'intel_allocator_bst.c',
 	'intel_allocator_msgchannel.c',
 	'intel_allocator_random.c',
 	'intel_allocator_reloc.c',
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#4 lore raw

PATCH 4/4 tests/i915_api_intel_allocator: Add the BST allocator

In reply to Andrzej Turko

Include the BST allocator in the allocator test.

Cc Zbigniew Kempczyński <[email protected]>
---
 tests/i915/api_intel_allocator.c | 55 ++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 20 deletions(-)
tests/i915/api_intel_allocator.c +35 -20
index 4b74317ed..45e62cd59 100644
@@ -25,13 +25,13 @@ static inline uint32_t gem_handle_gen(void)
 	return atomic_fetch_add(&next_handle, 1);
 }
 
-static void alloc_simple(int fd)
+static void alloc_sanity_check(int fd, uint8_t type)
 {
 	uint64_t ahnd;
 	uint64_t offset0, offset1, size = 0x1000, align = 0x1000, start, end;
 	bool is_allocated, freed;
 
-	ahnd = intel_allocator_open(fd, 0, INTEL_ALLOCATOR_SIMPLE);
+	ahnd = intel_allocator_open(fd, 0, type);
 
 	offset0 = intel_allocator_alloc(ahnd, 1, size, align);
 	offset1 = intel_allocator_alloc(ahnd, 1, size, align);
@@ -67,12 +67,12 @@ static void alloc_simple(int fd)
 	igt_assert_eq(intel_allocator_close(ahnd), true);
 }
 
-static void reserve_simple(int fd)
+static void reserve_sanity_check(int fd, uint8_t type)
 {
 	uint64_t ahnd, start, size = 0x1000;
 	bool reserved, unreserved;
 
-	ahnd = intel_allocator_open(fd, 0, INTEL_ALLOCATOR_SIMPLE);
+	ahnd = intel_allocator_open(fd, 0, type);
 	intel_allocator_get_address_range(ahnd, &start, NULL);
 
 	reserved = intel_allocator_reserve(ahnd, 0, size, start);
@@ -194,17 +194,19 @@ static void reuse(int fd, uint8_t type)
 	}
 	i--;
 
-	/* free previously allocated bo */
-	intel_allocator_free(ahnd, obj[i].handle);
-	/* alloc different buffer to fill freed hole */
-	tmp.handle = gem_handle_gen();
-	tmp.offset = intel_allocator_alloc(ahnd, tmp.handle, OBJ_SIZE, 0);
-	igt_assert(prev_offset == tmp.offset);
+	if (type == INTEL_ALLOCATOR_SIMPLE) {
+		/* free previously allocated bo */
+		intel_allocator_free(ahnd, obj[i].handle);
+		/* alloc different buffer to fill freed hole */
+		tmp.handle = gem_handle_gen();
+		tmp.offset = intel_allocator_alloc(ahnd, tmp.handle, OBJ_SIZE, 0);
+		igt_assert(prev_offset == tmp.offset);
 
-	obj[i].offset = intel_allocator_alloc(ahnd, obj[i].handle,
-					      obj[i].size, 0);
-	igt_assert(prev_offset != obj[i].offset);
-	intel_allocator_free(ahnd, tmp.handle);
+		obj[i].offset = intel_allocator_alloc(ahnd, obj[i].handle,
+						      obj[i].size, 0);
+		igt_assert(prev_offset != obj[i].offset);
+		intel_allocator_free(ahnd, tmp.handle);
+	}
 
 	for (i = 0; i < 128; i++)
 		intel_allocator_free(ahnd, obj[i].handle);
@@ -665,6 +667,7 @@ struct allocators {
 	{"simple", INTEL_ALLOCATOR_SIMPLE},
 	{"reloc",  INTEL_ALLOCATOR_RELOC},
 	{"random", INTEL_ALLOCATOR_RANDOM},
+	{"bst", INTEL_ALLOCATOR_BST},
 	{NULL, 0},
 };
 
@@ -679,18 +682,30 @@ igt_main
 		srandom(0xdeadbeef);
 	}
 
-	igt_subtest_f("alloc-simple")
-		alloc_simple(fd);
+	igt_subtest_f("alloc-sanity-check-simple")
+		alloc_sanity_check(fd, INTEL_ALLOCATOR_SIMPLE);
 
-	igt_subtest_f("reserve-simple")
-		reserve_simple(fd);
+	igt_subtest_f("alloc-sanity-check-bst")
+		alloc_sanity_check(fd, INTEL_ALLOCATOR_BST);
+
+	igt_subtest_f("reserve-sanity-check-simple")
+		reserve_sanity_check(fd, INTEL_ALLOCATOR_SIMPLE);
+
+	igt_subtest_f("reserve-sanity-check-bst")
+		reserve_sanity_check(fd, INTEL_ALLOCATOR_BST);
 
-	igt_subtest_f("reuse")
+	igt_subtest_f("reuse-simple")
 		reuse(fd, INTEL_ALLOCATOR_SIMPLE);
 
-	igt_subtest_f("reserve")
+	igt_subtest_f("reuse-bst")
+		reuse(fd, INTEL_ALLOCATOR_BST);
+
+	igt_subtest_f("reserve-simple")
 		reserve(fd, INTEL_ALLOCATOR_SIMPLE);
 
+	igt_subtest_f("reserve-bst")
+		reserve(fd, INTEL_ALLOCATOR_BST);
+
 	for (a = als; a->name; a++) {
 		igt_subtest_with_dynamic_f("%s-allocator", a->name) {
 			igt_dynamic("basic")
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

[igt-dev] ✗ Fi.CI.BUILD: failure for Implement the BST allocator

In reply to Andrzej Turko
== Series Details ==

== Series Details ==

Series: Implement the BST allocator
URL : https://patchwork.freedesktop.org/series/92760/
State : failure

== Summary ==

IGT patchset build failed on latest successful build 6caef22e4aafed275771f564d4ea4cab09896ebc tests/kms_dither: Make dither tests generic

ninja: Entering directory `build'
[1/806] Generating version.h with a custom command.
[2/803] Linking static target lib/libigt-igt_collection_c.a.
[3/803] Linking static target lib/libigt-igt_bst_avl_c.a.
[4/803] Linking static target lib/libigt-gpu_cmds_c.a.
[5/803] Linking static target lib/libigt-igt_syncobj_c.a.
[6/803] Linking static target lib/libigt-intel_allocator_c.a.
[7/803] Compiling C object 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
ccache cc -Ilib/lib@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/alsa -I/usr/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/opt/igt/share/igt-gpu-tools"' '-DIGT_SRCDIR="/home/cidrm/igt-gpu-tools/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

  hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                       ^~
../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
    offset_bst->get_value(offset_bst, nodeptr);
    ^~~~~~~~~~

ninja: build stopped: subcommand failed.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for Implement the BST allocator

In reply to Andrzej Turko
== Series Details ==

== Series Details ==

Series: Implement the BST allocator
URL : https://patchwork.freedesktop.org/series/92760/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/363561 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977590):
[2/912] Linking static target lib/libigt-igt_device_scan_c.a.
[3/912] Linking static target lib/libigt-intel_allocator_c.a.
[4/912] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                         ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
      offset_bst->get_value(offset_bst, nodeptr);
      ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787797:step_script
section_start:1626787797:cleanup_file_variables
Cleaning up file based variables
section_end:1626787798:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977593):
[4/906] Linking static target lib/libigt-igt_aux_c.a.
[5/906] Linking static target lib/libigt-gpu_cmds_c.a.
[6/906] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
/usr/bin/aarch64-linux-gnu-gcc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/aarch64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                         ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
      offset_bst->get_value(offset_bst, nodeptr);
      ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787801:step_script
section_start:1626787801:cleanup_file_variables
Cleaning up file based variables
section_end:1626787802:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977592):
[1/841] Generating version.h with a custom command.
[2/838] Linking static target lib/libigt-gpgpu_fill_c.a.
[3/838] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
/usr/bin/arm-linux-gnueabihf-gcc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/arm-linux-gnueabihf -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                         ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
      offset_bst->get_value(offset_bst, nodeptr);
      ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787801:step_script
section_start:1626787801:cleanup_file_variables
Cleaning up file based variables
section_end:1626787803:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977594):
[5/853] Linking static target lib/libigt-intel_allocator_c.a.
[6/853] Linking static target lib/libigt-instdone_c.a.
[7/853] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
/usr/bin/mips-linux-gnu-gcc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/mips-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                         ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
      offset_bst->get_value(offset_bst, nodeptr);
      ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787807:step_script
section_start:1626787807:cleanup_file_variables
Cleaning up file based variables
section_end:1626787810:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-minimal has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977591):
[6/255] Linking static target lib/libigt-gpu_cmds_c.a.
[7/255] Linking static target lib/libigt-intel_allocator_c.a.
[8/255] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I../lib/stubs/libunwind -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                         ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
      offset_bst->get_value(offset_bst, nodeptr);
      ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787799:step_script
section_start:1626787799:cleanup_file_variables
Cleaning up file based variables
section_end:1626787801:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977585):
[7/835] Linking static target lib/libigt-intel_allocator_c.a.
[8/835] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/opt/igt/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    429 |  hole = igt_bst_query_predecessor(ialb->offset_bst, start);
        |                                       ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
    601 |    offset_bst->get_value(offset_bst, nodeptr);
        |    ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787787:step_script
section_start:1626787787:cleanup_file_variables
Cleaning up file based variables
section_end:1626787788:cleanup_file_variables
ERROR: Failed to cleanup volumes
ERROR: Job failed: exit code 1

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977589):
[7/854] Linking static target lib/libigt-igt_syncobj_c.a.
[8/854] Linking static target lib/libigt-instdone_c.a.
[9/854] Linking static target lib/libigt-intel_allocator_c.a.
[10/854] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
clang -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c:429:41: error: no member named 'offset_bst' in 'struct intel_allocator_bst'

          hole = igt_bst_query_predecessor(ialb->offset_bst, start);
                                           ~~~~  ^
  ../lib/intel_allocator_bst.c:601:38: error: too many arguments to function call, expected 1, have 2
                          offset_bst->get_value(offset_bst, nodeptr);
                          ~~~~~~~~~~~~~~~~~~~~~             ^~~~~~~

2 errors generated.
ninja: build stopped: subcommand failed.
section_end:1626787803:step_script
section_start:1626787803:cleanup_file_variables
Cleaning up file based variables
section_end:1626787803:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977588):
[7/755] Linking static target lib/libigt-intel_allocator_c.a.
[8/755] Linking static target lib/libigt-instdone_c.a.
[9/755] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    429 |  hole = igt_bst_query_predecessor(ialb->offset_bst, start);
        |                                       ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
    601 |    offset_bst->get_value(offset_bst, nodeptr);
        |    ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787797:step_script
section_start:1626787797:cleanup_file_variables
Cleaning up file based variables
section_end:1626787798:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977586):
[2/917] Linking static target lib/libigt-igt_device_scan_c.a.
[3/917] Linking static target lib/libigt-intel_iosf_c.a.
[4/917] Compiling C object 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/76b5a35@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/libunwind -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/76b5a35@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    429 |  hole = igt_bst_query_predecessor(ialb->offset_bst, start);
        |                                       ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
    601 |    offset_bst->get_value(offset_bst, nodeptr);
        |    ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787797:step_script
section_start:1626787797:cleanup_file_variables
Cleaning up file based variables
section_end:1626787798:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11977587):
[2/913] Linking static target lib/libigt-intel_reg_map_c.a.
[3/913] Linking static target lib/libigt-intel_allocator_c.a.
[4/913] Compiling C object 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o'.
FAILED: lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o
cc -Ilib/lib@@igt-intel_allocator_bst_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/usr/local/share/igt-gpu-tools"' '-DIGT_SRCDIR="/builds/gfx-ci/igt-ci-tags/tests"' '-DIGT_LOG_DOMAIN="intel_allocator_bst"' -MD -MQ 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -MF 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o.d' -o 'lib/lib@@igt-intel_allocator_bst_c@sta/intel_allocator_bst.c.o' -c ../lib/intel_allocator_bst.c ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_reserve’:
../lib/intel_allocator_bst.c:429:39: error: ‘struct intel_allocator_bst’ has no member named ‘offset_bst’

    429 |  hole = igt_bst_query_predecessor(ialb->offset_bst, start);
        |                                       ^~
  ../lib/intel_allocator_bst.c: In function ‘intel_allocator_bst_print’:
  ../lib/intel_allocator_bst.c:601:4: error: too many arguments to function ‘offset_bst->get_value’
    601 |    offset_bst->get_value(offset_bst, nodeptr);
        |    ^~~~~~~~~~

ninja: build stopped: subcommand failed.
section_end:1626787797:step_script
section_start:1626787797:cleanup_file_variables
Cleaning up file based variables
section_end:1626787798:cleanup_file_variables
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/363561
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev