ALSA: sc6000: Fix incorrect sizeof operator
Subsystems (2)
PATCH 1/1 ALSA: sc6000: Fix incorrect sizeof operator
From: Colin Ian King <[email protected]>
Static analysis is warning that the sizeof being used is should be of *vport and not vport. Although these are the same size it is not a portable assumption to assume this is true for all cases. Fix this by using sizeof(*vport).
Addresses-Coverity: ("Sizeof not portable")
--- sound/isa/sc6000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/isa/sc6000.c +1 -1
@@ -552,7 +552,7 @@ static int snd_sc6000_probe(struct device *devptr, unsigned int dev) err =snd_devm_card_new (devptr, index[dev], id[dev],THIS_MODULE , -sizeof (vport), &card); +sizeof (*vport), &card);if (err <0 )return err;
Signature · 1 line
2.31.1
Quoted 11 lines · Colin King
From: Colin Ian King <[email protected]>
Static analysis is warning that the sizeof being used is should be of *vport and not vport. Although these are the same size it is not a portable assumption to assume this is true for all cases. Fix this by using
sizeof(*vport).Addresses-Coverity: ("Sizeof not portable")
Fixes 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")Signed-off-by Colin Ian King <[email protected]>
Thanks. I have another patch to drop this allocation (it's just a pointer, so no need for kmalloc, really), but since your patch is correct, I'll rebase on yours.
Takashi