Skip to contentSkip to conversation

scsi: lpfc: remove redundant assignment to pointer pcmd

PATCH Applied Colin King 2 participants 3 messages Jul 21, 2021 – Jul 29, 2021

Subsystems (3)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 scsi: lpfc: remove redundant assignment to pointer pcmd

From: Colin Ian King <[email protected]>

The pointer pcmd is being initialized with a value that is never read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")

---
 drivers/scsi/lpfc/lpfc_sli.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/lpfc/lpfc_sli.c +0 -2
index c34240819d92..47dd13719901 100644
@@ -10129,8 +10129,6 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,
 		bf_set(wqe_ebde_cnt, &wqe->xmit_els_rsp.wqe_com, 0);
 		bf_set(wqe_rsp_temp_rpi, &wqe->xmit_els_rsp,
 		       phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
-		pcmd = (uint32_t *) (((struct lpfc_dmabuf *)
-					iocbq->context2)->virt);
 		if (phba->fc_topology == LPFC_TOPOLOGY_LOOP) {
 				bf_set(els_rsp64_sp, &wqe->xmit_els_rsp, 1);
 				bf_set(els_rsp64_sid, &wqe->xmit_els_rsp,
Signature · 1 line
2.31.1
#1 lore raw

Colin,

Quoted 2 lines

The pointer pcmd is being initialized with a value that is never read, the assignment is redundant and can be removed.

Applied to 5.15/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering