drm/panfrost: devfreq: Don't display error for EPROBE_DEFER
Subsystems (3)
PATCH 1/1 drm/panfrost: devfreq: Don't display error for EPROBE_DEFER
From: Chris Morgan <[email protected]>
Set a condition for the message of "Couldn't set OPP regulators" to not display if the error code is EPROBE_DEFER. Note that I used an if statement to capture the condition instead of the dev_err_probe function because I didn't want to change the DRM_DEV_ERROR usage.
--- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/panfrost/panfrost_devfreq.c +2 -1
@@ -106,7 +106,8 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev)if (ret) {/* Continue if the optional regulator is missing */ if (ret != -ENODEV ) { -DRM_DEV_ERROR (dev,"Couldn't set OPP regulators\n" ); +if (ret != -EPROBE_DEFER ) +DRM_DEV_ERROR (dev,"Couldn't set OPP regulators\n" );return ret; } }
Signature · 1 line
2.25.1
Quoted 6 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Set a condition for the message of "Couldn't set OPP regulators" to not display if the error code is
EPROBE_DEFER. Note that I used an if statement to capture the condition instead of thedev_err_probefunction because I didn't want to change theDRM_DEV_ERRORusage.
Note that this file (panfost_devfreq.c) is actually the odd one out in terms of using the DRM_DEV_xxx macros. The rest of the panfrost driver uses the standard dev_xxx ones. So tidying this up to match the rest of the driver would also allow us to use dev_err_probe(). But as a point fix this patch is fine and correct. Thanks!
Quoted 1 line
Signed-off-by Chris Morgan <[email protected]>
I'll apply this to drm-misc-next.
Thanks,
Steve
Quoted 19 lines
--- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/panfrost/panfrost_devfreq.c +2
-1@@ -106,7 +106,8 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev)if (ret) {/* Continue if the optional regulator is missing */ if (ret != -ENODEV ) { -DRM_DEV_ERROR (dev,"Couldn't set OPP regulators\n" ); +if (ret != -EPROBE_DEFER ) +DRM_DEV_ERROR (dev,"Couldn't set OPP regulators\n" );return ret; } }