bits_clear and bits_set: Track bits cleared and set inside a function
PATCH 1/1 bits_clear and bits_set: Track bits cleared and set inside a function
Whenever a bit is set or cleared using bitwise operations inside a funciton body, the states are set using database entries.
Signed-off-by Harshvardhan Jha <[email protected]>
--- Makefile | 2 + check_list.h | 2 + smatch.h | 21 +++++++++ smatch_bits.c | 69 ++++++++++++++++++++++++---- smatch_extra.c | 26 +++++++---- smatch_param_bits_clear.c | 96 +++++++++++++++++++++++++++++++++++++++ smatch_param_bits_set.c | 76 +++++++++++++++++++++++++++++++ 7 files changed, 272 insertions(+), 20 deletions(-) create mode 100644 smatch_param_bits_clear.c create mode 100644 smatch_param_bits_set.c
Makefile +2 -0
@@ -290,6 +290,8 @@ SMATCH_OBJS += smatch_mtag_data.o SMATCH_OBJS += smatch_mtag_map.o SMATCH_OBJS += smatch_mtag.o SMATCH_OBJS += smatch_nul_terminator.o +SMATCH_OBJS += smatch_param_bits_set.o +SMATCH_OBJS += smatch_param_bits_clear.o SMATCH_OBJS += smatch_param_cleared.o SMATCH_OBJS += smatch_param_compare_limit.o SMATCH_OBJS += smatch_parameter_names.o
check_list.h +2 -0
@@ -169,6 +169,8 @@ CK(check_atomic_test) CK(check_checking_for_null_instead_of_err_ptr) CK(check_syscall_arg_type) CK(check_trinity_generator) +CK(register_param_bits_set) +CK(register_param_bits_clear)/* <- your test goes here */ /* CK(register_template) */
smatch.h +21 -0
@@ -848,6 +848,10 @@ enum info_type {FRESH_ALLOC =1044 ,ALLOCATOR =1045 ,FUNC_TIME =1047 , +BIT_SET =1051 , +BIT_CLEAR =1052 , +BIT_IS_SET =1053 , +BIT_IS_CLEAR =1054 ,/* put random temporary stuff in the 7000-7999 range for testing */ USER_DATA = 8017,
@@ -1311,10 +1315,27 @@ int get_mtag_sval(struct expression *expr, sval_t *sval);/* Trinity fuzzer stuff */ const char *get_syscall_arg_type (struct symbol *sym); +/* smatch_bits.c */ +int binfo_equiv (struct bit_info *one,struct bit_info *two); +struct bit_info *alloc_bit_info (unsigned long long set,unsigned long long possible); +struct smatch_state *alloc_bstate (unsigned long long set,unsigned long long possible); +struct smatch_state *merge_bstates (struct smatch_state *one_state,struct smatch_state *two_state); + +/* smatch_param_bits_set.c */ +void __set_param_modified_helper (struct expression *expr,struct smatch_state *state); +void __set_param_modified_helper_sym (const char *name,struct symbol *sym, +struct smatch_state *state); + +/* smatch_param_bits_clear.c */ +void __set_param_modified_helper_clear (struct expression *expr,struct smatch_state *state); +void __set_param_modified_helper_sym_clear (const char *name,struct symbol *sym, +struct smatch_state *state); +/* smatch_bit_info.c */ struct bit_info *rl_to_binfo (struct range_list *rl);struct bit_info *get_bit_info (struct expression *expr);struct bit_info *get_bit_info_var_sym (const char *name,struct symbol *sym); +/* smatch_mem_tracker.c */ extern int option_mem;unsigned long get_mem_kb (void );
smatch_bits.c +59 -10
117 lines not on this page · raw message
smatch_extra.c +16 -10
@@ -2059,7 +2059,7 @@ static sval_t get_high_mask(sval_t known)static bool handle_bit_test (struct expression *expr) { -struct range_list *orig_rl, *rl; +struct range_list *orig_rl, *rlt, *rlf, *true_rl, *false_rl;struct expression *shift, *mask, *var;struct bit_info *bit_info;sval_t sval;
@@ -2081,23 +2081,29 @@ static bool handle_bit_test(struct expression *expr) bit_info =get_bit_info (mask);if (!bit_info)return false; -if (!bit_info->possible) +if (!bit_info->possible){ +set_true_false_states_expr (my_id, var,alloc_estate_empty (),NULL );return false; + }get_absolute_rl (var, &orig_rl);if (sval_is_negative (rl_min (orig_rl)) ||rl_max (orig_rl).uvalue >type_bits (get_type (shift->left)))return false; - low.value =ffsll (bit_info->possible); - high.value =sm_fls64 (bit_info->possible); - rl =alloc_rl (low, high); - rl =cast_rl (get_type (var), rl); - rl =rl_intersection (orig_rl, rl); -if (!rl) -return false; + low.value =ffsll (bit_info->possible) -1 ; + high.value =sm_fls64 (bit_info->possible) -1 ; + rlt =alloc_rl (low, high); + rlt =cast_rl (get_type (var), rlt); + true_rl =rl_intersection (orig_rl, rlt); + + low.value =ffsll (bit_info->set) -1 ; + high.value =sm_fls64 (bit_info->set) -1 ; + rlf =alloc_rl (low, high); + rlf =cast_rl (get_type (var), rlf); + false_rl =rl_filter (orig_rl, rlf); -set_extra_expr_true_false (shift->right,alloc_estate_rl (rl),NULL ); +set_extra_expr_true_false (shift->right,alloc_estate_rl (true_rl),alloc_estate_rl (false_rl));return true; }
smatch_param_bits_clear.c new file +96 -0
96 lines not on this page · raw message
smatch_param_bits_set.c new file +76 -0
76 lines not on this page · raw message
Signature · 1 line
2.32.0