Skip to contentSkip to conversation

staging: rtl8188eu: Line over 100 characters

PATCH In review Jignesh Patel 3 participants 4 messages Jul 22, 2021 – Jul 23, 2021 Staging

lore
Share & tools
lore

Jignesh Patel

author
#0 lore raw

PATCH 1/1 staging: rtl8188eu: Line over 100 characters

Break various lines into multiple lines to respect 100 character width limit. Reported by checkpatch.pl

Signed-off-by Jignesh Patel <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_ap.c +5 -2
index b817aa8b9de4..b83d6da01b7c 100644
@@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
 			updated = ap_free_sta(padapter, psta, true,
 					      WLAN_REASON_DEAUTH_LEAVING);
 		} else {
-			/* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
+			/** TODO: Aging mechanism to digest frames in
+			 *  sleep_q to avoid running out of xmitframe
+			 */
 			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
-			    padapter->xmitpriv.free_xmitframe_cnt < (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
+			    padapter->xmitpriv.free_xmitframe_cnt <
+			    (NR_XMITFRAME / pstapriv->asoc_list_cnt / 2))
 				wakeup_sta_to_xmit(padapter, psta);
 		}
 	}
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 13 lines · Jignesh Patel

Break various lines into multiple lines to respect 100 character width limit. Reported by checkpatch.pl

Signed-off-by Jignesh Patel <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_ap.c +0 -0
index b817aa8b9de4..b83d6da01b7c 100644

drivers/staging/rtl8188eu/core/rtw_ap.c void expire_timeout_chk(struct adapter *padapter) · line 257

Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_ap.c +1 -1
@@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
 			updated = ap_free_sta(padapter, psta, true,
 					      WLAN_REASON_DEAUTH_LEAVING);
 		} else {
-			/* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
+			/** TODO: Aging mechanism to digest frames in

Does this line look correct now?

Please look at how comments are formatted...

thanks,

greg k-h

#2 lore raw
In reply to Jignesh Patel
Quoted 1 line · Jignesh Patel

Break various lines into multiple lines to respect 100 character width limit.

[]

drivers/staging/rtl8188eu/core/rtw_ap.c

Quoted 1 line
drivers/staging/rtl8188eu/core/rtw_ap.c +0 -0

[]

drivers/staging/rtl8188eu/core/rtw_ap.c void expire_timeout_chk(struct adapter *padapter) · line 257

Quoted 6 lines
drivers/staging/rtl8188eu/core/rtw_ap.c +1 -1
@@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
  			updated = ap_free_sta(padapter, psta, true,
  					      WLAN_REASON_DEAUTH_LEAVING);
  		} else {
-			/* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
+			/** TODO: Aging mechanism to digest frames in

Please do not use double asterisks to start a comment.