ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails
Subsystems (2)
PATCH 1/1 ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails
The copy_from_user() function returns the number of bytes remaining to be copied but we should return -EFAULT here.
Fixes 007888f365c9 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/char/ipmi/ssif_bmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/char/ipmi/ssif_bmc.c +2 -3
@@ -85,9 +85,8 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_tif (count >sizeof (struct ssif_msg ))return -EINVAL ; - ret =copy_from_user (&msg, buf, count); -if (ret) -return ret; +if (copy_from_user (&msg, buf, count)) +return -EFAULT ;if (!msg.len || count <ssif_msg_len (&msg))return -EINVAL ;
Signature · 1 line
2.20.1
Quoted 2 lines · Dan Carpenter
The
copy_from_user()function returns the number of bytes remaining to be copied but we should return-EFAULThere.
Yep, this is in my queue.
Thanks,
-corey
Quoted 26 lines
Fixes 007888f365c9 ("ipmi: ssif_bmc: Add SSIF BMC driver")Signed-off-by Dan Carpenter <[email protected]>--- drivers/char/ipmi/ssif_bmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/char/ipmi/ssif_bmc.c +2
-3@@ -85,9 +85,8 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_tif (count >sizeof (struct ssif_msg ))return -EINVAL ; - ret =copy_from_user (&msg, buf, count); -if (ret) -return ret; +if (copy_from_user (&msg, buf, count)) +return -EFAULT ;if (!msg.len || count <ssif_msg_len (&msg))return -EINVAL ;Signature · 1 line
2.20.1