Skip to contentSkip to conversation

gpu: host1x: select CONFIG_SYNC_FILE

PATCH In review Arnd Bergmann 2 participants 3 messages Jul 23, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: select CONFIG_SYNC_FILE

From: Arnd Bergmann <[email protected]>

With the addition of the DMA fence, the host1x driver now fails to build without the sync_file helper:

arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
fence.c:(.text+0x624): undefined reference to `sync_file_create'

Fixes ad0529424def ("gpu: host1x: Add DMA fence implementation")
---
 drivers/gpu/host1x/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +1 -0
index 6dab94adf25e..6f7ea1720a39 100644
@@ -3,6 +3,7 @@ config TEGRA_HOST1X
 	tristate "NVIDIA Tegra host1x driver"
 	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
 	select IOMMU_IOVA
+	select SYNC_FILE
 	help
 	  Driver for the NVIDIA Tegra host1x hardware.
 
Signature · 1 line
2.29.2
#1 lore raw

Hi Arnd,

I think the best fix for this is to just remove that function -- it is currently not used anywhere. I posted a patch to do that, but Thierry is currently on vacation so it hasn't been picked up yet.

thanks,
Mikko

Quoted 27 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

With the addition of the DMA fence, the host1x driver now fails to build without the sync_file helper:

arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
fence.c:(.text+0x624): undefined reference to `sync_file_create'

Fixes ad0529424def ("gpu: host1x: Add DMA fence implementation")
---
  drivers/gpu/host1x/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +1 -0
index 6dab94adf25e..6f7ea1720a39 100644
@@ -3,6 +3,7 @@ config TEGRA_HOST1X
  	tristate "NVIDIA Tegra host1x driver"
  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
  	select IOMMU_IOVA
+	select SYNC_FILE
  	help
  	  Driver for the NVIDIA Tegra host1x hardware.
 
#2 lore raw
Quoted 3 lines · Mikko Perttunen

Hi Arnd,

I think the best fix for this is to just remove that function -- it is currently not used anywhere. I posted a patch to do that, but Thierry is currently on vacation so it hasn't been picked up yet.

.. and sorry for the top post ..

Mikko

Quoted 31 lines

thanks,
Mikko

Quoted 26 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

With the addition of the DMA fence, the host1x driver now fails to build without the sync_file helper:

arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
fence.c:(.text+0x624): undefined reference to `sync_file_create'

Fixes ad0529424def ("gpu: host1x: Add DMA fence implementation")

---
  drivers/gpu/host1x/Kconfig | 1 +

  1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +0 -0
index 6dab94adf25e..6f7ea1720a39 100644
@@ -3,6 +3,7 @@ config TEGRA_HOST1X

      tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST) select IOMMU_IOVA
+    select SYNC_FILE
      help
        Driver for the NVIDIA Tegra host1x hardware.