f2fs: fix wrong checkpoint_changed value in f2fs_remount()
Chao Yu
maintainerPATCH 1/1 f2fs: fix wrong checkpoint_changed value in f2fs_remount()
In f2fs_remount(), return value of test_opt() is an unsigned int type variable, however when we compare it to a bool type variable, it cause wrong result, fix it.
Fixes 4354994f097d ("f2fs: checkpoint disabling")
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
fs/f2fs/super.c +2 -5
@@ -2062,11 +2062,10 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)bool need_restart_ckpt = false, need_stop_ckpt = false;bool need_restart_flush = false, need_stop_flush = false;bool no_extent_cache = !test_opt (sbi,EXTENT_CACHE ); -bool disable_checkpoint =test_opt (sbi,DISABLE_CHECKPOINT ); +bool enable_checkpoint = !test_opt (sbi,DISABLE_CHECKPOINT );bool no_io_align = !F2FS_IO_ALIGNED (sbi);bool no_atgc = !test_opt (sbi,ATGC );bool no_compress_cache = !test_opt (sbi,COMPRESS_CACHE ); -bool checkpoint_changed;#ifdef CONFIG_QUOTA int i, j;#endif
@@ -2111,8 +2110,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) err =parse_options (sb, data, true);if (err) goto restore_opts; - checkpoint_changed = - disable_checkpoint !=test_opt (sbi,DISABLE_CHECKPOINT );/* * Previous and new state of filesystem is RO,
@@ -2234,7 +2231,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) need_stop_flush = true; } -if (checkpoint_changed) { +if (enable_checkpoint == !!test_opt (sbi,DISABLE_CHECKPOINT )) {if (test_opt (sbi,DISABLE_CHECKPOINT )) { err =f2fs_disable_checkpoint (sbi);if (err)
Signature · 1 line
2.22.1