fpga: versal-fpga: Remove empty functions
Moritz Fischer
maintainerPATCH 1/1 fpga: versal-fpga: Remove empty functions
Since the core framework now wraps the functions, ensuring drives only have to implement functions that do something, drop the now no longer required callbacks for state and write_complete.
---
Hi Greg,
This needs to wait for the earlier pull request [1] that introduces the wrapper functions, allowing drivers to drop the empty ones.
Unfortunately this sort of got of sync with the versal patches getting picked up before the wrapper changes went in.
- Moritz
[1] https://lore.kernel.org/linux-fpga/[email protected]/
--- drivers/fpga/versal-fpga.c | 13 ------------- 1 file changed, 13 deletions(-)
drivers/fpga/versal-fpga.c +0 -13
@@ -37,22 +37,9 @@ static int versal_fpga_ops_write(struct fpga_manager *mgr,return ret; } -static int versal_fpga_ops_write_complete (struct fpga_manager *mgr, -struct fpga_image_info *info) -{ -return 0 ; -} - -static enum fpga_mgr_states versal_fpga_ops_state (struct fpga_manager *mgr) -{ -return FPGA_MGR_STATE_UNKNOWN ; -} -static const struct fpga_manager_ops versal_fpga_ops = { - .state = versal_fpga_ops_state, .write_init = versal_fpga_ops_write_init, .write = versal_fpga_ops_write, - .write_complete = versal_fpga_ops_write_complete, };static int versal_fpga_probe (struct platform_device *pdev)
Signature · 1 line
2.32.0
Quoted 8 lines · Moritz Fischer
Since the core framework now wraps the functions, ensuring drives only have to implement functions that do something, drop the now no longer required callbacks for state and
write_complete.Signed-off-by Moritz Fischer <[email protected]>---
Quoted 7 lines
Hi Greg,
This needs to wait for the earlier pull request [1] that introduces the wrapper functions, allowing drivers to drop the empty ones.
Unfortunately this sort of got of sync with the versal patches getting picked up before the wrapper changes went in.
As I said to your pull request, you can now add it to the new request you will be sending me :)
thanks,
greg k-h