lib/i915/gem_mman: add FIXED mmap mode
PATCH 1/7 lib/i915/gem_mman: add FIXED mmap mode
We need this for discrete.
--- lib/i915/gem_mman.c | 37 +++++++++++++++++++++++++++++++++++++ lib/i915/gem_mman.h | 4 ++++ 2 files changed, 41 insertions(+)
lib/i915/gem_mman.c +37 -0
@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4 + +void *__gem_mmap_offset__fixed (int fd,uint32_t handle,uint64_t offset, +uint64_t size,unsigned prot) +{ +return __gem_mmap_offset (fd, handle, offset, size, prot, +LOCAL_I915_MMAP_OFFSET_FIXED ); +} + +/** +* gem_mmap_offset__fixed: Used to mmap objects on discrete platforms +* @fd: open i915 drm file descriptor +* @handle: gem buffer object handle +* @offset: offset in the gem buffer of the mmap arena +* @size: size of the mmap arena +* @prot: memory protection bits as used by mmap() +* +* Like __gem_mmap_offset__fixed() except we assert on failure. +* +* For discrete the caching attributes for the pages are fixed at allocation +* time, and can't be changed. The FIXED mode will simply use the same caching * +* mode of the allocated pages. This mode will always be coherent with GPU +* access. +* +* On non-discrete platforms this mode is not supported. +* +* Returns: A pointer to the created memory mapping +*/ +void *gem_mmap_offset__fixed (int fd,uint32_t handle,uint64_t offset, +uint64_t size,unsigned prot) +{ +void *ptr =__gem_mmap_offset__fixed (fd, handle, offset, size, prot); + +igt_assert (ptr); +return ptr; +} +/** * __gem_mmap__cpu_coherent: * @fd: open i915 drm file descriptor
lib/i915/gem_mman.h +4 -0
@@ -37,6 +37,8 @@ bool gem_mmap_offset__has_wc(int fd);void *gem_mmap__wc (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot);void *gem_mmap_offset__wc (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot); +void *gem_mmap_offset__fixed (int fd,uint32_t handle,uint64_t offset, +uint64_t size,unsigned prot);void *gem_mmap__device_coherent (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot); void *gem_mmap__cpu_coherent(int fd, uint32_t handle, uint64_t offset,
@@ -54,6 +56,8 @@ void *__gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,void *__gem_mmap__wc (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot);void *__gem_mmap_offset__wc (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot); +void *__gem_mmap_offset__fixed (int fd,uint32_t handle,uint64_t offset, +uint64_t size,unsigned prot);void *__gem_mmap__device_coherent (int fd,uint32_t handle,uint64_t offset,uint64_t size,unsigned prot); void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/7 lib/i915/gem_mman: add fixed mode to mmap__device_coherent
On discrete we need to fallback to this mode.
--- lib/i915/gem_mman.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/i915/gem_mman.c +2 -1
@@ -383,9 +383,10 @@ void *__gem_mmap__device_coherent(int fd, uint32_t handle, uint64_t offset, I915_MMAP_OFFSET_WC);if (!ptr) ptr =__gem_mmap__wc (fd, handle, offset, size, prot); -if (!ptr) ptr =__gem_mmap__gtt (fd, handle, size, prot); +if (!ptr) + ptr =__gem_mmap_offset__fixed (fd, handle, offset, size, prot);return ptr; }
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/7 lib/i915/gem_mman: add fixed mode to mmap__cpu_coherent
In reply to Matthew AuldOn discrete we only support the new fixed mode.
--- lib/i915/gem_mman.c | 2 ++ 1 file changed, 2 insertions(+)
lib/i915/gem_mman.c +2 -0
@@ -580,6 +580,8 @@ void *gem_mmap__cpu_coherent(int fd, uint32_t handle, uint64_t offset,igt_assert (offset ==0 ); ptr =__gem_mmap__cpu_coherent (fd, handle, offset, size, prot); +if (!ptr) + ptr =__gem_mmap_offset__fixed (fd, handle, offset, size, prot);igt_assert (ptr);return ptr;
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/7 lib/i915/gem_mman: update mmap_offset_types with FIXED
In reply to Matthew AuldWe need to also iterate the fixed mode in the tests which rely on this.
--- lib/i915/gem_mman.c | 1 + 1 file changed, 1 insertion(+)
lib/i915/gem_mman.c +1 -0
@@ -611,6 +611,7 @@ const struct mmap_offset mmap_offset_types[] = { { "wb", I915_MMAP_OFFSET_WB, I915_GEM_DOMAIN_CPU }, { "wc", I915_MMAP_OFFSET_WC, I915_GEM_DOMAIN_WC }, { "uc", I915_MMAP_OFFSET_UC, I915_GEM_DOMAIN_WC }, + { "fixed", LOCAL_I915_MMAP_OFFSET_FIXED, 0}, {}, };
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/7 lib/ioctl_wrappers: update mmap_{read, write} for discrete
In reply to Matthew AuldWe can no longer just call get_caching or set_domain, and the mmap mode must be FIXED. This should bring back gem_exec_basic and a few others in CI on DG1.
--- lib/ioctl_wrappers.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)
lib/ioctl_wrappers.c +23 -2
@@ -339,7 +339,18 @@ static void mmap_write(int fd, uint32_t handle, uint64_t offset,if (!length)return ; -if (is_cache_coherent (fd, handle)) { +if (gem_has_lmem (fd)) { +/* +* set/get_caching and set_domain are no longer supported on +* discrete, also the only mmap mode supportd is FIXED. +*/ + map =gem_mmap_offset__fixed (fd, handle,0 , + offset + length, +PROT_READ |PROT_WRITE ); +igt_assert_eq (gem_wait (fd, handle,0 ),0 ); + } + +if (!map &&is_cache_coherent (fd, handle)) {/* offset arg for mmap functions must be 0 */ map =__gem_mmap__cpu_coherent (fd, handle,0 , offset + length,PROT_READ |PROT_WRITE );
@@ -369,7 +380,17 @@ static void mmap_read(int fd, uint32_t handle, uint64_t offset, void *buf, uint6if (!length)return ; -if (gem_has_llc (fd) ||is_cache_coherent (fd, handle)) { +if (gem_has_lmem (fd)) { +/* +* set/get_caching and set_domain are no longer supported on +* discrete, also the only supported mmap mode is FIXED. +*/ + map =gem_mmap_offset__fixed (fd, handle,0 , + offset + length,PROT_READ ); +igt_assert_eq (gem_wait (fd, handle,0 ),0 ); + } + +if (!map && (gem_has_llc (fd) ||is_cache_coherent (fd, handle))) {/* offset arg for mmap functions must be 0 */ map =__gem_mmap__cpu_coherent (fd, handle,0 , offset + length,PROT_READ );
Signature · 6 lines
2.26.3 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 5/7] lib/ioctl_wrappers: update mmap_{read, write} for discrete
Quoted 4 lines · Matthew Auld
We can no longer just call
get_cachingorset_domain, and the mmap mode must be FIXED. This should bring backgem_exec_basicand a few others in CI on DG1.
We should probably also similarly update mmap_{read, write} in lib/intel_bufops.c.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 6/7 lib/ioctl_wrappers: update set_domain for discrete
In reply to Matthew AuldOn discrete set_domain is now gone, instead we just need to add the wait.
--- lib/ioctl_wrappers.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
lib/ioctl_wrappers.c +6 -1
@@ -565,7 +565,12 @@ int __gem_set_domain(int fd, uint32_t handle, uint32_t read, uint32_t write)*/ void gem_set_domain (int fd,uint32_t handle,uint32_t read,uint32_t write) { -igt_assert_eq (__gem_set_domain (fd, handle, read, write),0 ); +int ret =__gem_set_domain (fd, handle, read, write); + +if (ret == -ENODEV &&gem_has_lmem (fd)) +igt_assert_eq (gem_wait (fd, handle,0 ),0 ); +else +igt_assert_eq (ret,0 ); }/**
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/7 tests/i915/module_load: update for discrete
In reply to Matthew AuldThe set_caching ioctl is gone for discrete, and now just returns -ENODEV. Update the gem_sanitycheck to account for that. After this we should be back to just having the breakage caused by missing reloc support for the reload testcase.
--- tests/i915/i915_module_load.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
tests/i915/i915_module_load.c +7 -2
@@ -172,17 +172,22 @@ static void gem_sanitycheck(void) {struct drm_i915_gem_caching args = {};int i915 =__drm_open_driver (DRIVER_INTEL ); +int expected;int err; + expected = -ENOENT ; +if (gem_has_lmem (i915)) + expected = -ENODEV ; + err =0 ;if (ioctl (i915,DRM_IOCTL_I915_GEM_SET_CACHING , &args)) err = -errno; -if (err == -ENOENT ) +if (err == expected)store_all (i915); errno =0 ;close (i915); -igt_assert_eq (err, -ENOENT ); +igt_assert_eq (err, expected); } static void
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] lib/i915/gem_mman: add FIXED mmap mode
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/7] lib/i915/gem_mman: add FIXED mmap mode
URL : https://patchwork.freedesktop.org/series/93008/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10394 -> IGTPW_6057
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/index.html
Known issues
------------
Here are the changes found in IGTPW_6057 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@runner@aborted:
- fi-kbl-7500u: NOTRUN -> [FAIL][1] ([i915#1814] / [i915#3363])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][2] ([i915#1888]) -> [PASS][3] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/fi-tgl-u2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/fi-tgl-u2/igt@[email protected]
* igt@gem_sync@basic-all:
- {fi-dg1-1}: [FAIL][4] ([i915#3717]) -> [PASS][5] +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/fi-dg1-1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/fi-dg1-1/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- {fi-jsl-1}: [INCOMPLETE][6] -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/fi-jsl-1/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/fi-jsl-1/igt@i915_selftest@[email protected]
- {fi-hsw-gt1}: [DMESG-WARN][8] ([i915#3303]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/fi-hsw-gt1/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/fi-hsw-gt1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3626]: https://gitlab.freedesktop.org/drm/intel/issues/3626
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
Participating hosts (42 -> 35)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-adls-4 bat-adls-3 fi-bdw-samus bat-jsl-1
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6150 -> IGTPW_6057
CI-20190529: 20190529
CI_DRM_10394: e2ddb2cf7c4ae6795fa72f072e5caac4d332cd49 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6057: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/index.html
IGT_6150: 08c084830e1b30409df513f94ccdce84f950ced0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/7] lib/i915/gem_mman: add FIXED mmap mode
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/7] lib/i915/gem_mman: add FIXED mmap mode
URL : https://patchwork.freedesktop.org/series/93008/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10394_full -> IGTPW_6057_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6057_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_6057_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6057_full:
### IGT changes ###
#### Possible regressions ####
* {igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@fixed} (NEW):
- shard-iclb: NOTRUN -> [SKIP][1] +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb6/igt@gem_userptr_blits@[email protected]
* {igt@gem_userptr_blits@map-fixed-invalidate@fixed} (NEW):
- shard-tglb: NOTRUN -> [SKIP][2] +5 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@gem_userptr_blits@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-glk: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk1/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_10394_full and IGTPW_6057_full:
### New IGT tests (7) ###
* igt@gem_ctx_sseu@mmap-args@fixed:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_userptr_blits@map-fixed-invalidate-busy@fixed:
- Statuses : 5 skip(s)
- Exec time: [0.00, 0.01] s
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@fixed:
- Statuses : 6 skip(s)
- Exec time: [0.00, 0.01] s
* igt@gem_userptr_blits@map-fixed-invalidate-overlap@fixed:
- Statuses : 5 skip(s)
- Exec time: [0.00, 0.01] s
* igt@gem_userptr_blits@map-fixed-invalidate@fixed:
- Statuses : 6 skip(s)
- Exec time: [0.00, 0.02] s
* igt@gem_userptr_blits@mmap-offset-banned@fixed:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@perf_pmu@faulting-read@fixed:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_6057_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@device_reset@unbind-reset-rebind:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#2283])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-kbl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl6/igt@[email protected]
- shard-iclb: [PASS][7] -> [DMESG-WARN][8] ([i915#1602] / [i915#2283])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb7/igt@[email protected]
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2846])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-kbl3/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl2/igt@[email protected]
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2846])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk4/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk6/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][14] ([i915#2846])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl7/igt@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#2842] / [i915#3468])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-apl3/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2842]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-tglb6/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb8/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk8/igt@gem_exec_fair@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][24] ([i915#2658])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb2/igt@[email protected]
* igt@gem_userptr_blits@coherency-unsync:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#3297])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb3/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3323])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl6/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][27] ([i915#2724])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb7/igt@[email protected]
* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109289]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@[email protected]
* igt@gen9_exec_parse@valid-registers:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#2856])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#2856])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb6/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#111614])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb7/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk7/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3777]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111615]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#110723])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb6/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3689]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278]) +14 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb8/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +32 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb7/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb7/igt@[email protected]
* igt@kms_color@pipe-d-degamma:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#1149])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb8/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +23 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +4 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk9/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][46] ([i915#1319])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109278] / [fdo#109279]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109279] / [i915#3359])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +49 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#3359]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-size-change:
- shard-kbl: [PASS][51] -> [FAIL][52] ([i915#3444]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-kbl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl3/igt@[email protected]
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#3444])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk1/igt@[email protected]
- shard-apl: [PASS][55] -> [FAIL][56] ([i915#3444])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-apl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x256-random:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271]) +50 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk6/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][58] ([fdo#109271]) +384 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb6/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#109278])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@[email protected]
* igt@kms_flip@2x-busy-flip:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb5/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][61] -> [DMESG-WARN][62] ([i915#180])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-apl7/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2672])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#111825]) +18 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109280]) +17 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][66] -> [SKIP][67] ([i915#433])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-tglb3/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb7/igt@[email protected]
* igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#109289]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb6/igt@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#533])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk7/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][73] ([i915#265]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658]) +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl7/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#2920])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb6/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][76] -> [SKIP][77] ([fdo#109642] / [fdo#111068] / [i915#658])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb2/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk4/igt@kms_psr2_su@page_flip.html
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#1911])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@kms_psr2_su@page_flip.html
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl4/igt@kms_psr2_su@page_flip.html
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109642] / [fdo#111068] / [i915#658])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb8/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109441])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
- shard-tglb: NOTRUN -> [FAIL][83] ([i915#132] / [i915#3467])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb6/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109441]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr@sprite_render:
- shard-tglb: [PASS][86] -> [DMESG-WARN][87] ([i915#2868])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-tglb3/igt@kms_psr@sprite_render.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@kms_psr@sprite_render.html
* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][88] ([i915#31])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-snb6/igt@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][89] ([IGT#2])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl7/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271]) +331 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl8/igt@[email protected]
* igt@kms_vrr@flip-suspend:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109502])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#109502])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb7/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2437])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2437]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2437])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#2437])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#2437])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb5/igt@[email protected]
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109278] / [i915#2530]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb5/igt@[email protected]
* igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [PASS][100] -> [FAIL][101] ([i915#1542])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk2/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk1/igt@[email protected]
* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109291]) +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb7/igt@prime_nv_api@i915_nv_import_twice.html
* igt@prime_nv_test@i915_import_cpu_mmap:
- shard-tglb: NOTRUN -> [SKIP][103] ([fdo#109291]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb3/igt@prime_nv_test@i915_import_cpu_mmap.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#2994]) +4 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl8/igt@[email protected]
* igt@sysfs_clients@recycle-many:
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#2994]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk7/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2994]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][108] ([i915#2994]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][109] ([i915#3063]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-tglb6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][111] ([i915#2842]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-tglb3/igt@gem_exec_fair@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][113] ([i915#2842]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-kbl2/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][115] ([i915#2842]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk4/igt@gem_exec_fair@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [FAIL][117] ([i915#2842] / [i915#3468]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk4/igt@gem_exec_fair@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][119] ([i915#2842]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb7/igt@gem_exec_fair@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][121] ([fdo#109271]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-kbl1/igt@gem_exec_fair@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][123] ([i915#2849]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb5/igt@gem_exec_fair@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][125] ([i915#118] / [i915#95]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-glk6/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-glk2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: [DMESG-WARN][127] ([i915#3621]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-iclb: [SKIP][129] ([i915#3788]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb2/igt@kms_dither@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@kms_dither@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][131] ([i915#180]) -> [PASS][132] +4 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-apl8/igt@kms_flip@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][133] ([fdo#109441]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][135] ([i915#2852]) -> [FAIL][136] ([i915#2842])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb3/igt@gem_exec_fair@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][137] ([i915#1804] / [i915#2684]) -> [WARN][138] ([i915#2684])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10394/shard-iclb4/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/shard-iclb1/igt@[email protected]
* igt@kms_psr2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6057/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
lib/i915/gem_mman.c void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, · line 500
Quoted 10 lines · Matthew Auld
lib/i915/gem_mman.c +1
-0@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4
This use of LOCAL declarations is more related to the methodology we follow in IGT rather than this patch. We have seen in the past that such LOCAL's linger on in the code for months and years till someone decides to clean them so the question is can we prevent these LOCAL's from getting introduced in the first place.
One reason for these is that we sync IGT headers with drm-next whereas IGT is used to test drm-tip. So the delta between the two results in such LOCAL's as in this case.
My proposal is that even if we don't start sync'ing IGT headers with drm-tip (instead of drm-next) we allow direct modification of the headers when needed to avoid introducing such LOCAL's. So in the above case we would add:
#define I915_MMAP_OFFSET_FIXED 4
to i915_drm.h as part of this patch and then just use I915_MMAP_OFFSET_FIXED. If another sync happens from drm-next before this #define has appeared there, the compile will break and whoever syncs will need to add this again to i915_drm.h.
What do people think about a scheme such as this? The other, perhaps better, option of course is to sync the headers directly with drm-tip (whenever and as often as needed). But the goal in both cases is to avoid LOCAL's, or other things like #ifndef's distributed throughout multiple source files which we also do in such cases. A centralized internal header to contain such declarations might not be so bad. Thanks.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 37 lines · Ashutosh
lib/i915/gem_mman.c void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, · line 500
Quoted 10 lines · Matthew Auld
lib/i915/gem_mman.c +1
-0@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4Cc @Petri LatvalaThis use of LOCAL declarations is more related to the methodology we follow in IGT rather than this patch. We have seen in the past that such LOCAL's linger on in the code for months and years till someone decides to clean them so the question is can we prevent these LOCAL's from getting introduced in the first place.
One reason for these is that we sync IGT headers with drm-next whereas IGT is used to test drm-tip. So the delta between the two results in such LOCAL's as in this case.
My proposal is that even if we don't start sync'ing IGT headers with drm-tip (instead of drm-next) we allow direct modification of the headers when needed to avoid introducing such LOCAL's. So in the above case we would add:
#define
I915_MMAP_OFFSET_FIXED4to
i915_drm.has part of this patch and then just useI915_MMAP_OFFSET_FIXED. If another sync happens from drm-next before this #define has appeared there, the compile will break and whoever syncs will need to add this again toi915_drm.h.
Quoted 6 lines
What do people think about a scheme such as this? The other, perhaps better, option of course is to sync the headers directly with drm-tip (whenever and as often as needed). But the goal in both cases is to avoid LOCAL's, or other things like #ifndef's distributed throughout multiple source files which we also do in such cases. A centralized internal header to contain such declarations might not be so bad. Thanks.
I have submitted a patch based on this last statement here:
https://patchwork.freedesktop.org/series/93096/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 29 lines · Ashutosh
lib/i915/gem_mman.c void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, · line 500
Quoted 10 lines · Matthew Auld
lib/i915/gem_mman.c +1
-0@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4Cc @Petri LatvalaThis use of LOCAL declarations is more related to the methodology we follow in IGT rather than this patch. We have seen in the past that such LOCAL's linger on in the code for months and years till someone decides to clean them so the question is can we prevent these LOCAL's from getting introduced in the first place.
One reason for these is that we sync IGT headers with drm-next whereas IGT is used to test drm-tip. So the delta between the two results in such LOCAL's as in this case.
My proposal is that even if we don't start sync'ing IGT headers with drm-tip (instead of drm-next) we allow direct modification of the headers when needed to avoid introducing such LOCAL's. So in the above case we would add:
Quoted 6 lines
#define
I915_MMAP_OFFSET_FIXED4to
i915_drm.has part of this patch and then just useI915_MMAP_OFFSET_FIXED. If another sync happens from drm-next before this #define has appeared there, the compile will break and whoever syncs will need to add this again toi915_drm.h.
I don't like that kind of a breakage at all. That enforces mandatory fixups to some poor developer working on unrelated code who doesn't necessarily know how to even fix it easily.
Of course an argument can be made that it's an i915 token in an i915 header so it will be the i915 people doing it, but for a general case that's going to cause more harm than it solves problems, I feel.
Quoted 6 lines
What do people think about a scheme such as this? The other, perhaps better, option of course is to sync the headers directly with drm-tip (whenever and as often as needed). But the goal in both cases is to avoid LOCAL's, or other things like #ifndef's distributed throughout multiple source files which we also do in such cases. A centralized internal header to contain such declarations might not be so bad. Thanks.
A separate manually written header for new tokens that are not yet in drm-next might be the least bad of all options. Although now that I've said it, the perfect world would have new tokens done like this:
#ifndef I915_MMAP_OFFSET_FIXED
#define I915_MMAP_OFFSET_FIXED 4
#else_Static_assert(I915_MMAP_OFFSET_FIXED == 4, "ABI broken, yikes"); #endif
In a different language wrapping all that in a
MAYBE_DECLARE(I915_MMAP_OFFSET_FIXED, 4)
might be easier but with C preprocessor it's a bit more... involved. A separate build-time script to generate that header maybe? Such a script could also just completely omit the definition if header copies already introduce the token.
Recap:
1) We have kernel headers copied into IGT to ensure it builds fine without latest-and-greatest headers installed on the system.
2) Copies are from drm-next to ensure the next person to copy the headers doesn't accidentally drop definitions that originate from a vendor-specific tree. (That same reason is also for why one shouldn't edit the headers manually)
3) To get to drm-next, the kernel code needs to be tested with IGT first, so we need new definitions to test that kernel code in some form.
4) LOCAL_* definitions that are cleaned up later when actual definitions reach drm-next sounds good in theory but in practice the cleaning part is often forgotten.
Either way, I think the code using new definitions should use the intended final names so we should just entirely drop the practice of declaring anything LOCAL_*. That way the cleanup is limited to one place.
Signature · 5 lines
Petri Latvala _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 38 lines · Petri Latvala
Quoted 29 lines · Ashutosh
lib/i915/gem_mman.c void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, · line 500
Quoted 10 lines · Matthew Auld
lib/i915/gem_mman.c +1
-0@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4Cc @Petri LatvalaThis use of LOCAL declarations is more related to the methodology we follow in IGT rather than this patch. We have seen in the past that such LOCAL's linger on in the code for months and years till someone decides to clean them so the question is can we prevent these LOCAL's from getting introduced in the first place.
One reason for these is that we sync IGT headers with drm-next whereas IGT is used to test drm-tip. So the delta between the two results in such LOCAL's as in this case.
My proposal is that even if we don't start sync'ing IGT headers with drm-tip (instead of drm-next) we allow direct modification of the headers when needed to avoid introducing such LOCAL's. So in the above case we would add:
Quoted 6 lines
#define
I915_MMAP_OFFSET_FIXED4to
i915_drm.has part of this patch and then just useI915_MMAP_OFFSET_FIXED. If another sync happens from drm-next before this #define has appeared there, the compile will break and whoever syncs will need to add this again toi915_drm.h.
Quoted 7 lines
I don't like that kind of a breakage at all. That enforces mandatory fixups to some poor developer working on unrelated code who doesn't necessarily know how to even fix it easily.
Of course an argument can be made that it's an i915 token in an i915 header so it will be the i915 people doing it, but for a general case that's going to cause more harm than it solves problems, I feel.
OK, let's not change anything with the headers we import for now.
Quoted 17 lines
Quoted 6 lines
What do people think about a scheme such as this? The other, perhaps better, option of course is to sync the headers directly with drm-tip (whenever and as often as needed). But the goal in both cases is to avoid LOCAL's, or other things like #ifndef's distributed throughout multiple source files which we also do in such cases. A centralized internal header to contain such declarations might not be so bad. Thanks.
A separate manually written header for new tokens that are not yet in drm-next might be the least bad of all options. Although now that I've said it, the perfect world would have new tokens done like this:
#ifndef
I915_MMAP_OFFSET_FIXED
#defineI915_MMAP_OFFSET_FIXED4
#else_Static_assert(I915_MMAP_OFFSET_FIXED == 4, "ABI broken, yikes"); #endif
Quoted 8 lines
In a different language wrapping all that in a
MAYBE_DECLARE(I915_MMAP_OFFSET_FIXED, 4)might be easier but with C preprocessor it's a bit more... involved. A separate build-time script to generate that header maybe? Such a script could also just completely omit the definition if header copies already introduce the token.
IMO all this wouldn't do much more that what gcc already does. For example, for this:
#define I915_MMAP_OFFSET_FIXED 4
#define I915_MMAP_OFFSET_FIXED 4
gcc silently ignores the second #define, whereas for:
#define I915_MMAP_OFFSET_FIXED 4
#define I915_MMAP_OFFSET_FIXED 5
gcc will warn that second I915_MMAP_OFFSET_FIXED is redefined.
And gcc will error out on things like struct redeclaration.
Quoted 5 lines
Recap:
1) We have kernel headers copied into IGT to ensure it builds fine without latest-and-greatest headers installed on the system.
Quoted 8 lines
2) Copies are from drm-next to ensure the next person to copy the headers doesn't accidentally drop definitions that originate from a vendor-specific tree. (That same reason is also for why one shouldn't edit the headers manually)
3) To get to drm-next, the kernel code needs to be tested with IGT first, so we need new definitions to test that kernel code in some form.
I guess it is possible to test with "Test-with:" and merge the kernel changes first and the IGT changes later with the correct headers but maybe it's inconvenient? But don't we merge the kernel changes before IGT?
Quoted 8 lines
4) LOCAL_* definitions that are cleaned up later when actual definitions reach drm-next sounds good in theory but in practice the cleaning part is often forgotten.
Either way, I think the code using new definitions should use the intended final names so we should just entirely drop the practice of declaring anything LOCAL_*. That way the cleanup is limited to one place.
In any case, any thoughts about the i915_drm_local.h patch I posted:
https://patchwork.freedesktop.org/series/93096/
I am not asking for any other changes to anything at this this point. I have also started asking people to not use the LOCAL_ or local_ prefix any more in code reviews. But I probably still prefer that these declarations move to a central place such as i915_drm_local.h if possible so it's easier to clean them up later. Thanks.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 81 lines · Ashutosh
Quoted 38 lines · Petri Latvala
Quoted 29 lines · Ashutosh
lib/i915/gem_mman.c void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, · line 500
Quoted 10 lines · Matthew Auld
lib/i915/gem_mman.c +1
-0@@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset,return ptr; } +#define LOCAL_I915_MMAP_OFFSET_FIXED 4Cc @Petri LatvalaThis use of LOCAL declarations is more related to the methodology we follow in IGT rather than this patch. We have seen in the past that such LOCAL's linger on in the code for months and years till someone decides to clean them so the question is can we prevent these LOCAL's from getting introduced in the first place.
One reason for these is that we sync IGT headers with drm-next whereas IGT is used to test drm-tip. So the delta between the two results in such LOCAL's as in this case.
My proposal is that even if we don't start sync'ing IGT headers with drm-tip (instead of drm-next) we allow direct modification of the headers when needed to avoid introducing such LOCAL's. So in the above case we would add:
Quoted 6 lines
#define
I915_MMAP_OFFSET_FIXED4to
i915_drm.has part of this patch and then just useI915_MMAP_OFFSET_FIXED. If another sync happens from drm-next before this #define has appeared there, the compile will break and whoever syncs will need to add this again toi915_drm.h.Quoted 7 lines
I don't like that kind of a breakage at all. That enforces mandatory fixups to some poor developer working on unrelated code who doesn't necessarily know how to even fix it easily.
Of course an argument can be made that it's an i915 token in an i915 header so it will be the i915 people doing it, but for a general case that's going to cause more harm than it solves problems, I feel.
OK, let's not change anything with the headers we import for now.
Quoted 17 lines
Quoted 6 lines
What do people think about a scheme such as this? The other, perhaps better, option of course is to sync the headers directly with drm-tip (whenever and as often as needed). But the goal in both cases is to avoid LOCAL's, or other things like #ifndef's distributed throughout multiple source files which we also do in such cases. A centralized internal header to contain such declarations might not be so bad. Thanks.
A separate manually written header for new tokens that are not yet in drm-next might be the least bad of all options. Although now that I've said it, the perfect world would have new tokens done like this:
#ifndef
I915_MMAP_OFFSET_FIXED
#defineI915_MMAP_OFFSET_FIXED4
#else_Static_assert(I915_MMAP_OFFSET_FIXED == 4, "ABI broken, yikes"); #endifQuoted 8 lines
In a different language wrapping all that in a
MAYBE_DECLARE(I915_MMAP_OFFSET_FIXED, 4)might be easier but with C preprocessor it's a bit more... involved. A separate build-time script to generate that header maybe? Such a script could also just completely omit the definition if header copies already introduce the token.
IMO all this wouldn't do much more that what gcc already does. For example, for this:
#define
I915_MMAP_OFFSET_FIXED4
#defineI915_MMAP_OFFSET_FIXED4
Quoted 8 lines
gcc silently ignores the second #define, whereas for:
#define
I915_MMAP_OFFSET_FIXED4
#defineI915_MMAP_OFFSET_FIXED5gcc will warn that second
I915_MMAP_OFFSET_FIXEDis redefined.And gcc will error out on things like struct redeclaration.
Ah that's good then!
(For the record, C99 6.10.3 states this is even standard C behaviour)
Quoted 11 lines
Quoted 11 lines
Recap:
1) We have kernel headers copied into IGT to ensure it builds fine without latest-and-greatest headers installed on the system.
2) Copies are from drm-next to ensure the next person to copy the headers doesn't accidentally drop definitions that originate from a vendor-specific tree. (That same reason is also for why one shouldn't edit the headers manually)
Quoted 7 lines
Quoted 3 lines
3) To get to drm-next, the kernel code needs to be tested with IGT first, so we need new definitions to test that kernel code in some form.
I guess it is possible to test with "Test-with:" and merge the kernel changes first and the IGT changes later with the correct headers but maybe it's inconvenient? But don't we merge the kernel changes before IGT?
Merge rules for kernel vs. userspace is like that, yes. But IGT doesn't count as userspace for those rules and merging order can be more relaxed.
Quoted 12 lines
Quoted 9 lines
4) LOCAL_* definitions that are cleaned up later when actual definitions reach drm-next sounds good in theory but in practice the cleaning part is often forgotten.
Either way, I think the code using new definitions should use the intended final names so we should just entirely drop the practice of declaring anything LOCAL_*. That way the cleanup is limited to one place.
In any case, any thoughts about the
i915_drm_local.hpatch I posted:
Quoted 7 lines
https://patchwork.freedesktop.org/series/93096/
I am not asking for any other changes to anything at this this point. I have also started asking people to not use the
LOCAL_orlocal_prefix any more in code reviews. But I probably still prefer that these declarations move to a central place such asi915_drm_local.hif possible so it's easier to clean them up later. Thanks.
Going to reply on that patch in a bit.
Signature · 5 lines
Petri Latvala _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx