Skip to contentSkip to conversation

GitHub Actions: fix MSVC builds

PATCH In review Lev Stipakov 2 participants 2 messages Jul 26, 2021 – Aug 1, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GitHub Actions: fix MSVC builds

From: Lev Stipakov <[email protected]...>

By reasons remain unknown, MSVC GitHub Actions started to fail after some irrelevant change.

While problem is also reproduced on my GitHub fork, I couldn't reproduce it locally. Despiteadding debug logging to GitHub Actions it is not clear what went wrong:

##[debug]Exit code '3221225477' received from command '"D:\a\openvpn\openvpn\vcpkg\vcpkg.exe"'

Turns out that update to a newer vcpkg commit fixed the problem.

---
 .github/workflows/build.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.github/workflows/build.yaml +1 -1
index 5d7dd37b..b2c16449 100644
@@ -211,7 +211,7 @@ jobs:
         with:
           vcpkgArguments: 'openssl lz4 lzo pkcs11-helper tap-windows6'
           vcpkgTriplet: '${{ matrix.triplet }}-windows-ovpn'
-          vcpkgGitCommitId: '7d472dd25830da92108eb76642c667aaa40512cb'
+          vcpkgGitCommitId: '261c458af6e3eed5d099144aff95d2b5035f656b'
           cleanAfterBuild: false
 
       - name: Build
Signature · 1 line
2.23.0.windows.1
Acked-by on v1 1/1
#1 lore raw

I do not need to understand this... but it's basically upgrading build prerequisites only for GH Actions, which does not affect anything else = if Lev says it's good, so I believe :-)

Your patch has been applied to the master branch.

commit 852d98efbd9dde09ff6dfedac19e54aeca1feee6

Author: Lev Stipakov
Date:   Tue Jul 27 01:39:20 2021 +0300
     GitHub Actions: fix MSVC builds

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg22678.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering