Skip to contentSkip to conversation

test-runner: set msize to remove runtime warning

PATCH In review James Prestwood 2 participants 3 messages Jul 27, 2021 – Jul 28, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 test-runner: set msize to remove runtime warning

Newer QEMU version warn that msize is set too low and may result in poor IO performance. The default is 8KiB which QEMU claims is too low. Explicitly setting to 10KiB removes the warning:

qemu-system-x86_64: warning: 9p: degraded performance: a reasonable high msize should be chosen on client/guest side (chosen msize is <= 8192).
See https://wiki.qemu.org/Documentation/9psetup#msize for details.

---
 tools/test-runner | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/test-runner +1 -1
index bc37b80c..98164f7a 100755
@@ -1364,7 +1364,7 @@ def run_tests():
 	config.ctx = TestContext(args)
 
 	if args.log:
-		mount('logdir', args.log, '9p', 0, 'trans=virtio,version=9p2000.L')
+		mount('logdir', args.log, '9p', 0, 'trans=virtio,version=9p2000.L,msize=10240')
 		# Clear out any log files from other test runs
 		for f in glob('%s/*' % args.log):
 			print("removing %s" % f)
Signature · 1 line
2.31.1
#1 lore raw

PATCH 2/2 auto-t: fix blacklist test ranking

The scan ranking logic was previously changed to be based off a theoretical calculated data rate rather than signal strength. For HT/VHT networks there are many data points that can be used for this calculation, but non HT/VHT networks are estimated based on a simple table mapping signal strengths to data rates.

This table starts at a signal strength of -65 dBm and decreases from there, meaning any signal strengths greater than -65 dBm will end up getting the same ranking. This poses a problem for 3/4 blacklisting tests as they set signal strengths ranging from -20 to -40 dBm. IWD will then autoconnect to whatever network popped up first, which may not be the expected network.

To fix this the signal strengths were changed to much lower values which ensures IWD picks the expected network.

---
 autotests/testBSSBlacklist/bad_pass_test.py       | 4 ++--
 autotests/testBSSBlacklist/connection_test.py     | 4 ++--
 autotests/testBSSBlacklist/temp_blacklist_test.py | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
autotests/testBSSBlacklist/bad_pass_test.py +2 -2
index b0a81991..1d41f390 100644
@@ -32,12 +32,12 @@ class Test(unittest.TestCase):
         rule1 = hwsim.rules.create()
         rule1.source = bss_radio[1].addresses[0]
         rule1.bidirectional = True
-        rule1.signal = -3000
+        rule1.signal = -7000
 
         rule2 = hwsim.rules.create()
         rule2.source = bss_radio[2].addresses[0]
         rule2.bidirectional = True
-        rule2.signal = -4000
+        rule2.signal = -8000
 
         wd = IWD(True)
 
autotests/testBSSBlacklist/connection_test.py +2 -2
index 111ae582..58931d3e 100644
@@ -34,12 +34,12 @@ class Test(unittest.TestCase):
         rule1 = hwsim.rules.create()
         rule1.source = bss_radio[1].addresses[0]
         rule1.bidirectional = True
-        rule1.signal = -3000
+        rule1.signal = -7000
 
         rule2 = hwsim.rules.create()
         rule2.source = bss_radio[2].addresses[0]
         rule2.bidirectional = True
-        rule2.signal = -4000
+        rule2.signal = -8000
 
         wd = IWD(True)
 
autotests/testBSSBlacklist/temp_blacklist_test.py +1 -1
index efb848e9..02438f89 100644
@@ -32,7 +32,7 @@ class Test(unittest.TestCase):
         rule1 = hwsim.rules.create()
         rule1.source = bss_radio[1].addresses[0]
         rule1.bidirectional = True
-        rule1.signal = -2500
+        rule1.signal = -7000
 
         rule2 = hwsim.rules.create()
         rule2.source = bss_radio[2].addresses[0]
Signature · 1 line
2.31.1
#2 lore raw
In reply to James Prestwood

Hi James,

Quoted 4 lines · James Prestwood

Newer QEMU version warn that msize is set too low and may result in poor IO performance. The default is 8KiB which QEMU claims is too low. Explicitly setting to 10KiB removes the warning:

Quoted 8 lines

qemu-system-x86_64: warning: 9p: degraded performance: a reasonable high msize should be chosen on client/guest side (chosen msize is <= 8192).
See https://wiki.qemu.org/Documentation/9psetup#msize for details.

---
  tools/test-runner | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks.

Regards,
-Denis