common/rc: only force nfs4.2 non-default SEEK_HOLE behaviour
Subsystems (2)
PATCH 1/1 common/rc: only force nfs4.2 non-default SEEK_HOLE behaviour
Only NFSv4.2 supports non-defautl SEEK_HOLE behaviour. Thus default SEEK_HOLE behaviour shall be allowed for NFSv4.0/4.1, or it will fail generic/285, generic/448, generic/490 on NFSv4.0/4.1, complaining they should support non-default SEEK_HOLE behaviour.
The *.full log is like:
File system supports the default behavior. Default behavior is not allowed. Aborting.
--- common/rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
common/rc +4 -4
@@ -2495,10 +2495,10 @@ _fstyp_has_non_default_seek_data_hole() return 0 ;; nfs*) - # NFSv2 and NFSv3 only support default behavior of SEEK_HOLE, - # while NFSv4 supports non-default behavior - local nfsvers=`_df_device $TEST_DEV | $AWK_PROG '{ print $2 }'` - [ "$nfsvers" = "nfs4" ] + # NFSv2, NFSv3, and NFSv4.0/4.1 only support default behavior of SEEK_HOLE, + # while NFSv4.2 supports non-default behavior + local nfsvers=`_mount() | grep $TEST_DEV | sed -n 's/^.*vers=\([0-9.]*\).*$/\1/p'` + [ "$nfsvers" = "4.2" ] return $? ;; overlay)
Signature · 1 line
2.27.0
[cc nfs list]
Quoted 10 lines · Jeffle Xu
Only NFSv4.2 supports non-defautl
SEEK_HOLEbehaviour. Thus defaultSEEK_HOLEbehaviour shall be allowed for NFSv4.0/4.1, or it will fail generic/285, generic/448, generic/490 on NFSv4.0/4.1, complaining they should support non-defaultSEEK_HOLEbehaviour.The *.full log is like:
File system supports the default behavior. Default behavior is not allowed. Aborting.Signed-off-by Jeffle Xu <[email protected]>
Looks correct to me, but I'd like nfs folks to take a look as well, to conform if only nfsv4.2 supports SEEK_DATA/SEEK_HOLE non-default behavior.
Thanks,
Eryu
P.S.
Please cc the corresponding filesystem list next time if patch affects the specific fs.
Quoted 25 lines
--- common/rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)common/rc +4
-4@@ -2495,10 +2495,10 @@ _fstyp_has_non_default_seek_data_hole() return 0 ;; nfs*) - # NFSv2 and NFSv3 only support default behavior of SEEK_HOLE, - # while NFSv4 supports non-default behavior - local nfsvers=`_df_device $TEST_DEV | $AWK_PROG '{ print $2 }'` - [ "$nfsvers" = "nfs4" ] + # NFSv2, NFSv3, and NFSv4.0/4.1 only support default behavior of SEEK_HOLE, + # while NFSv4.2 supports non-default behavior + local nfsvers=`_mount() | grep $TEST_DEV | sed -n 's/^.*vers=\([0-9.]*\).*$/\1/p'` + [ "$nfsvers" = "4.2" ] return $? ;; overlay)Signature · 1 line
2.27.0
Hi Eryu,
Quoted 13 lines · Eryu Guan
[cc nfs list]
Quoted 9 lines · Jeffle Xu
Only NFSv4.2 supports non-defautl
SEEK_HOLEbehaviour. Thus defaultSEEK_HOLEbehaviour shall be allowed for NFSv4.0/4.1, or it will fail generic/285, generic/448, generic/490 on NFSv4.0/4.1, complaining they should support non-defaultSEEK_HOLEbehaviour.The *.full log is like:
File system supports the default behavior.
Default behavior is not allowed. Aborting.
Quoted 5 lines
Quoted 1 line
Signed-off-by Jeffle Xu <[email protected]>Looks correct to me, but I'd like nfs folks to take a look as well, to conform if only nfsv4.2 supports SEEK_DATA/SEEK_HOLE non-default behavior.
This is correct, non-default SEEK_DATA/SEEK_HOLE is only supported by NFS v4.2.
Thanks for checking!
Anna
Quoted 33 lines
Thanks,
Eryu
P.S.
Please cc the corresponding filesystem list next time if patch affects the specific fs.Quoted 25 lines
--- common/rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)common/rc +4
-5@@ -2495,10 +2495,10 @@ _fstyp_has_non_default_seek_data_hole() return 0 ;; nfs*) - # NFSv2 and NFSv3 only support default behavior of SEEK_HOLE, - # while NFSv4 supports non-default behavior - local nfsvers=`_df_device $TEST_DEV | $AWK_PROG '{ print $2 }'` - [ "$nfsvers" = "nfs4" ] + # NFSv2, NFSv3, and NFSv4.0/4.1 only support default behavior of SEEK_HOLE, + # while NFSv4.2 supports non-default behavior + local nfsvers=`_mount() | grep $TEST_DEV | sed -n 's/^.*vers=\([0-9.]*\).*$/\1/p'` + [ "$nfsvers" = "4.2" ] return $? ;; overlay) --2.27.0