Skip to contentSkip to conversation

ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()

PATCH In review Dan Carpenter 2 participants 2 messages Jul 30, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()

I accidentally introduced a bug in my previous patch. The "ret" variable needs to be initialized to prevent returning uninitialized data.

Fixes f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails")

---
Sorry!

 drivers/char/ipmi/ssif_bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ssif_bmc.c +1 -1
index ce8cd8364a3f..acdb1d9cb5c0 100644
@@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
 	struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
 	struct ssif_msg msg;
 	unsigned long flags;
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	if (count > sizeof(struct ssif_msg))
 		return -EINVAL;
Signature · 1 line
2.20.1
#1 lore raw
Quoted 3 lines · Dan Carpenter

I accidentally introduced a bug in my previous patch. The "ret" variable needs to be initialized to prevent returning uninitialized data.

Thanks Dan, it's queued.

-corey

Quoted 25 lines
Fixes f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails")

---
Sorry!

 drivers/char/ipmi/ssif_bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ssif_bmc.c +1 -1
index ce8cd8364a3f..acdb1d9cb5c0 100644
@@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
 	struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
 	struct ssif_msg msg;
 	unsigned long flags;
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	if (count > sizeof(struct ssif_msg))
 		return -EINVAL;
Signature · 1 line
2.20.1