net: announce changes in TCP header
PATCH 1/1 net: announce changes in TCP header
Announce change to add a union that will provide byte and bitfield access to TCP flags.
--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -158,3 +158,6 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* net: structure ``rte_tcp_hdr`` will have a union that will provide + byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
Signature · 1 line
2.32.0
Quoted 9 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Gregory Etelson
Sent: Monday, August 2, 2021 13:42
To: [email protected]
Cc: Gregory Etelson <[email protected]>; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Ori Kam <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH] net: announce changes in TCP header
Quoted 4 lines
Announce change to add a union that will provide byte and bitfield access to TCP flags.
Signed-off-by Gregory Etelson <[email protected]>
Nobody rejected this change but there is not enough ack to make it an accepted announce of change.
02/08/2021 12:42, Gregory Etelson:
Quoted 7 lines
Announce change to add a union that will provide byte and bitfield access to TCP flags.
Signed-off-by Gregory Etelson <[email protected]>---
doc/guides/rel_notes/deprecation.rst +2
-0+* net: structure ``rte_tcp_hdr`` will have a union that will provide + byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
The patch lacks motivation. Why is the change required? Why is it useful?
Quoted 11 lines · On August 5, 2021 18:28:31 Thomas Monjalon <[email protected]> wrote:
Nobody rejected this change but there is not enough ack to make it an accepted announce of change.
02/08/2021 12:42, Gregory Etelson:
Quoted 7 lines
Announce change to add a union that will provide byte and bitfield access to TCP flags.
Signed-off-by Gregory Etelson <[email protected]>---
doc/guides/rel_notes/deprecation.rst +2
-0+* net: structure ``rte_tcp_hdr`` will have a union that will provide + byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
Hello,
The TCP flags bitfield patch complements similar changes
proposed to IPv4 header in net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/>
Regards,
Gregory
From: Andrew Rybchenko <[email protected]>
Sent: Friday, August 6, 2021 12:03
To: NBU-Contact-Thomas Monjalon <[email protected]>; Gregory Etelson <[email protected]>
Cc: [email protected]; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Ori Kam <[email protected]>; Ray Kinsella <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header
External email: Use caution opening links or attachments
The patch lacks motivation. Why is the change required? Why is it useful?
On August 5, 2021 18:28:31 Thomas Monjalon <[email protected]<mailto:[email protected]>> wrote:
Nobody rejected this change but there is not enough ack to make it an accepted announce of change.
02/08/2021 12:42, Gregory Etelson:
Announce change to add a union that will provide byte and bitfield access to TCP flags.
---
+* net: structure ``rte_tcp_hdr`` will have a union that will provide
+ byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
Quoted 7 lines · On Fri, 6 Aug 2021 13:56:56 +0000 Gregory Etelson <[email protected]> wrote:
Hello,
The TCP flags bitfield patch complements similar changes
proposed to IPv4 header in net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/>Regards,
Gregory
This version of patch is being dropped because it didn't have sufficient number of ack's for a new feature over a several year timeframe. If it is really useful then resubmit along with an example of where it could be used in DPDK.