Skip to contentSkip to conversation

dmaengine: idxd: Remove unused status variable in irq_process_work_list()

PATCH Applied Nathan Chancellor 3 participants 3 messages Aug 2, 2021 – Aug 6, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: idxd: Remove unused status variable in irq_process_work_list()

status is no longer used within this block:

drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' [-Wunused-variable]

                u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
                   ^

1 warning generated.

Fixes b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
---
 drivers/dma/idxd/irq.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/idxd/irq.c +0 -2
index 65dc7bbb0a13..91e46ca3a0ad 100644
@@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
 	spin_unlock_irqrestore(&irq_entry->list_lock, flags);
 
 	list_for_each_entry(desc, &flist, list) {
-		u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
-
 		/*
 		 * Check against the original status as ABORT is software defined
 		 * and 0xff, which DSA_COMP_STATUS_MASK can mask out.

base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d

Signature · 1 line
2.32.0.264.g75ae10bc75
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Nathan Chancellor

status is no longer used within this block:

drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' [-Wunused-variable]

                 u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
                    ^

1 warning generated.

Fixes b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")

Thanks.

Quoted 19 lines
---
  drivers/dma/idxd/irq.c | 2 --
  1 file changed, 2 deletions(-)
drivers/dma/idxd/irq.c +0 -2
index 65dc7bbb0a13..91e46ca3a0ad 100644
@@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
  	spin_unlock_irqrestore(&irq_entry->list_lock, flags);
 
  	list_for_each_entry(desc, &flist, list) {
-		u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
-
  		/*
  		 * Check against the original status as ABORT is software defined
  		 * and 0xff, which DSA_COMP_STATUS_MASK can mask out.

base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d

maintainer Applied
#2 lore raw
In reply to Nathan Chancellor
Quoted 7 lines · Nathan Chancellor

status is no longer used within this block:

drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' [-Wunused-variable]

                u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
                   ^

1 warning generated.

Applied, thanks

Signature · 1 line
~Vinod