scsi: qla2xxx: Fix use after free in debug code
Subsystems (3)
PATCH 1/1 scsi: qla2xxx: Fix use after free in debug code
The sp->free(sp); call frees "sp" and then the debug code dereferences it on the next line. Swap the order.
--- drivers/scsi/qla2xxx/qla_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_bsg.c +2 -2
@@ -25,12 +25,12 @@ void qla2x00_bsg_job_done(srb_t *sp, int res)struct bsg_job *bsg_job = sp->u.bsg_job;struct fc_bsg_reply *bsg_reply = bsg_job->reply; - sp->free (sp); -ql_dbg (ql_dbg_user, sp->vha,0x7009 ,"%s: sp hdl %x, result=%x bsg ptr %p\n" , __func__, sp->handle, res, bsg_job); + sp->free (sp); + bsg_reply->result = res;bsg_job_done (bsg_job, bsg_reply->result, bsg_reply->reply_payload_rcv_len);
Signature · 1 line
2.20.1
Quoted 32 lines · Dan Carpenter
The
sp->free(sp); call frees "sp" and then the debug code dereferences it on the next line. Swap the order.Fixes 84318a9f01ce ("scsi: qla2xxx: edif: Add send, receive, and accept for auth_els")Signed-off-by Dan Carpenter <[email protected]>--- drivers/scsi/qla2xxx/qla_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/qla2xxx/qla_bsg.c +2
-3@@ -25,12 +25,12 @@ void qla2x00_bsg_job_done(srb_t *sp, int res)struct bsg_job *bsg_job = sp->u.bsg_job;struct fc_bsg_reply *bsg_reply = bsg_job->reply; - sp->free (sp); -ql_dbg (ql_dbg_user, sp->vha,0x7009 ,"%s: sp hdl %x, result=%x bsg ptr %p\n" , __func__, sp->handle, res, bsg_job); + sp->free (sp); + bsg_reply->result = res;bsg_job_done (bsg_job, bsg_reply->result, bsg_reply->reply_payload_rcv_len); --2.20.1
Quoted 35 lines · Dan Carpenter
The
sp->free(sp); call frees "sp" and then the debug code dereferences it on the next line. Swap the order.Fixes 84318a9f01ce ("scsi: qla2xxx: edif: Add send, receive, and accept for auth_els")Signed-off-by Dan Carpenter <[email protected]>---
drivers/scsi/qla2xxx/qla_bsg.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/qla2xxx/qla_bsg.c +2
-2@@ -25,12 +25,12 @@ void qla2x00_bsg_job_done(srb_t *sp, int res)struct bsg_job *bsg_job = sp->u.bsg_job;struct fc_bsg_reply *bsg_reply = bsg_job->reply; - sp->free (sp); -ql_dbg (ql_dbg_user, sp->vha,0x7009 ,"%s: sp hdl %x, result=%x bsg ptr %p\n" , __func__, sp->handle, res, bsg_job); + sp->free (sp); + bsg_reply->result = res;bsg_job_done (bsg_job, bsg_reply->result, bsg_reply->reply_payload_rcv_len);Signature · 1 line
2.20.1
--
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedDan,
Quoted 2 lines
The
sp->free(sp); call frees "sp" and then the debug code dereferences it on the next line. Swap the order.
Applied to 5.15/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Dan Carpenter
The
sp->free(sp); call frees "sp" and then the debug code dereferences it on the next line. Swap the order.
Applied to 5.15/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix use after free in debug code
https://git.kernel.org/mkp/scsi/c/e3d2612f583b
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering