Skip to contentSkip to conversation

dt-bindings: net: qcom,ipa: make imem interconnect optional

PATCH Superseded Alex Elder 1 participant 2 messages Aug 4, 2021

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 dt-bindings: net: qcom,ipa: make imem interconnect optional

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Update the binding to indicate that having just the memory and config interconnects is another allowed configuration.

---
Rob, Bjorn, Andy:

This was posted as part of a small series once before, and accepted into the net-next/master branch by David Miller:
https://lore.kernel.org/netdev/[email protected]/

That series got reverted yesterday:
https://lore.kernel.org/netdev/[email protected]/

Now I'm posting this patch again (by itself, and a little different this time based on input from Rob) so that this patch can be taken through the Qualcomm repository. I will be posting other updates to DTS files in a separate series shortly.

I didn't copy networking addressees this time...

-Alex

 .../devicetree/bindings/net/qcom,ipa.yaml     | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +16 -8
index ed88ba4b94df5..b8a0b392b24ea 100644
@@ -87,16 +87,24 @@ properties:
       - const: ipa-setup-ready
 
   interconnects:
-    items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+    oneOf:
+      - items:
+          - description: Path leading to system memory
+          - description: Path between the AP and IPA config space
+      - items:
+          - description: Path leading to system memory
+          - description: Path leading to internal memory
+          - description: Path between the AP and IPA config space
 
   interconnect-names:
-    items:
-      - const: memory
-      - const: imem
-      - const: config
+    oneOf:
+      - items:
+          - const: memory
+          - const: config
+      - items:
+          - const: memory
+          - const: imem
+          - const: config
 
   qcom,smem-states:
     $ref: /schemas/types.yaml#/definitions/phandle-array
Signature · 1 line
2.27.0
author
#1 lore raw
Quoted 6 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Update the binding to indicate that having just the memory and config interconnects is another allowed configuration.

And now I realize I mistakenly based this on net-next/master rather than linux-next/master. I think I need to wait another day or so before I can apply this to the right branch.

Sorry about that. Please ignore/retract this, I'll send again when I can, and will call the update "v2".

-Alex

Quoted 60 lines

---
Rob, Bjorn, Andy:

This was posted as part of a small series once before, and accepted into the net-next/master branch by David Miller:

   https://lore.kernel.org/netdev/[email protected]/

That series got reverted yesterday:

   https://lore.kernel.org/netdev/[email protected]/

Now I'm posting this patch again (by itself, and a little different this time based on input from Rob) so that this patch can be taken through the Qualcomm repository. I will be posting other updates to DTS files in a separate series shortly.

I didn't copy networking addressees this time...

-Alex

  .../devicetree/bindings/net/qcom,ipa.yaml     | 24 ++++++++++++-------
  1 file changed, 16 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +16 -8
index ed88ba4b94df5..b8a0b392b24ea 100644
@@ -87,16 +87,24 @@ properties:
        - const: ipa-setup-ready
 
    interconnects:
-    items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+    oneOf:
+      - items:
+          - description: Path leading to system memory
+          - description: Path between the AP and IPA config space
+      - items:
+          - description: Path leading to system memory
+          - description: Path leading to internal memory
+          - description: Path between the AP and IPA config space
 
    interconnect-names:
-    items:
-      - const: memory
-      - const: imem
-      - const: config
+    oneOf:
+      - items:
+          - const: memory
+          - const: config
+      - items:
+          - const: memory
+          - const: imem
+          - const: config
 
    qcom,smem-states:
      $ref: /schemas/types.yaml#/definitions/phandle-array