Skip to contentSkip to conversation

rsi: fix error code in rsi_load_9116_firmware()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 5, 2021 – Aug 21, 2021

Subsystems (2)
Kernel janitors Redpine wireless driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 rsi: fix error code in rsi_load_9116_firmware()

This code returns success if the kmemdup() fails, but obviously it should return -ENOMEM instead.

Fixes e5a1ecc97e5f ("rsi: add firmware loading for 9116 device")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/net/wireless/rsi/rsi_91x_hal.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/rsi/rsi_91x_hal.c +3 -1
index 99b21a2c8386..f4a26f16f00f 100644
@@ -1038,8 +1038,10 @@ static int rsi_load_9116_firmware(struct rsi_hw *adapter)
 	}
 
 	ta_firmware = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL);
-	if (!ta_firmware)
+	if (!ta_firmware) {
+		status = -ENOMEM;
 		goto fail_release_fw;
+	}
 	fw_p = ta_firmware;
 	instructions_sz = fw_entry->size;
 	rsi_dbg(INFO_ZONE, "FW Length = %d bytes\n", instructions_sz);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 5 lines · Dan Carpenter

This code returns success if the kmemdup() fails, but obviously it should return -ENOMEM instead.

Fixes e5a1ecc97e5f ("rsi: add firmware loading for 9116 device")
Signed-off-by Dan Carpenter <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

d0f8430332a1 rsi: fix error code in rsi_load_9116_firmware()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20210805103746.GA26417@kili/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches