selftests/bpf: rename reference_tracking BPF programs
Subsystems (3)
Andrii Nakryiko
maintainerPATCH 1/1 selftests/bpf: rename reference_tracking BPF programs
BPF programs for reference_tracking selftest use "fail_" prefix to notify that they are expected to fail. This is really confusing and inconvenient when trying to grep through test_progs output to find *actually* failed tests. So rename the prefix from "fail_" to "err_".
--- .../selftests/bpf/prog_tests/reference_tracking.c | 4 ++-- .../selftests/bpf/progs/test_sk_lookup_kern.c | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-)
tools/testing/selftests/bpf/prog_tests/reference_tracking.c +2 -2
@@ -34,8 +34,8 @@ void test_reference_tracking(void)if (!test__start_subtest (title))continue ; -/* Expect verifier failure if test name has 'fail' */ -if (strstr (title,"fail" ) !=NULL ) { +/* Expect verifier failure if test name has 'err' */ +if (strstr (title,"err_" ) !=NULL ) {libbpf_print_fn_t old_print_fn; old_print_fn =libbpf_set_print (NULL );
tools/testing/selftests/bpf/progs/test_sk_lookup_kern.c +7 -7
@@ -91,7 +91,7 @@ int bpf_sk_lookup_test1(struct __sk_buff *skb)return 0 ; } -SEC("classifier/fail_use_after_free") +SEC("classifier/err_use_after_free")int bpf_sk_lookup_uaf (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -106,7 +106,7 @@ int bpf_sk_lookup_uaf(struct __sk_buff *skb)return family; } -SEC("classifier/fail_modify_sk_pointer") +SEC("classifier/err_modify_sk_pointer")int bpf_sk_lookup_modptr (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -121,7 +121,7 @@ int bpf_sk_lookup_modptr(struct __sk_buff *skb)return 0 ; } -SEC("classifier/fail_modify_sk_or_null_pointer") +SEC("classifier/err_modify_sk_or_null_pointer")int bpf_sk_lookup_modptr_or_null (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -135,7 +135,7 @@ int bpf_sk_lookup_modptr_or_null(struct __sk_buff *skb)return 0 ; } -SEC("classifier/fail_no_release") +SEC("classifier/err_no_release")int bpf_sk_lookup_test2 (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -144,7 +144,7 @@ int bpf_sk_lookup_test2(struct __sk_buff *skb)return 0 ; } -SEC("classifier/fail_release_twice") +SEC("classifier/err_release_twice")int bpf_sk_lookup_test3 (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -156,7 +156,7 @@ int bpf_sk_lookup_test3(struct __sk_buff *skb)return 0 ; } -SEC("classifier/fail_release_unchecked") +SEC("classifier/err_release_unchecked")int bpf_sk_lookup_test4 (struct __sk_buff *skb) {struct bpf_sock_tuple tuple = {};
@@ -173,7 +173,7 @@ void lookup_no_release(struct __sk_buff *skb)bpf_sk_lookup_tcp (skb, &tuple,sizeof (tuple),BPF_F_CURRENT_NETNS ,0 ); } -SEC("classifier/fail_no_release_subcall") +SEC("classifier/err_no_release_subcall")int bpf_sk_lookup_test5 (struct __sk_buff *skb) {lookup_no_release (skb);
Signature · 1 line
2.30.2
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Quoted 8 lines · On Thu, 5 Aug 2021 16:07:34 -0700 you wrote:
BPF programs for
reference_trackingselftest use "fail_" prefix to notify that they are expected to fail. This is really confusing and inconvenient when trying to grep throughtest_progsoutput to find *actually* failed tests. So rename the prefix from "fail_" to "err_".Signed-off-by Andrii Nakryiko <[email protected]>[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: rename reference_tracking BPF programs
https://git.kernel.org/bpf/bpf-next/c/579345e7f219
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html