Skip to contentSkip to conversation

Linux 5.10.56-rt49-rc1

PATCH New Steven Rostedt 1 participant 3 messages Aug 6, 2021 Printk

lore
Share & tools
lore

Steven Rostedt

author reviewer
#0 lore raw

cover Linux 5.10.56-rt49-rc1

Dear RT Folks,

This is the RT stable review cycle of patch 5.10.56-rt49-rc1.

Please scream at me if I messed something up. Please test the patches too.

The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release candidate).

The pre-releases will not be pushed to the git repository, only the final release is.

If all goes well, this patch will be converted to the next main release on 8/10/2021.

Enjoy,

-- Steve

To build 5.10.56-rt49-rc1 directly, the following patches should be applied:

http://www.kernel.org/pub/linux/kernel/v5.x/linux-5.10.tar.xz

http://www.kernel.org/pub/linux/kernel/v5.x/patch-5.10.56.xz

http://www.kernel.org/pub/linux/kernel/projects/rt/5.10/patch-5.10.56-rt49-rc1.patch.xz

You can also build from 5.10.56-rt48 by applying the incremental patch:

http://www.kernel.org/pub/linux/kernel/projects/rt/5.10/incr/patch-5.10.56-rt48-rt49-rc1.patch.xz

Changes from 5.10.56-rt48:

---

Chao Qin (1):
printk: Enhance the condition check of msleep in pr_flush()

Steven Rostedt (VMware) (1):

      Linux 5.10.56-rt49-rc1

----

 kernel/printk/printk.c | 4 +++-
 localversion-rt        | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
author reviewer
#1 lore raw

PATCH 1/2 printk: Enhance the condition check of msleep in pr_flush()

5.10.56-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Chao Qin <[email protected]>

[ Upstream commit 83e9288d9c4295d1195e9d780fcbc42c72ba4a83 ]

There is msleep in pr_flush(). If call WARN() in the early boot stage such as in early_initcall, pr_flush() will run into msleep when process scheduler is not ready yet. And then the system will sleep forever.

Before the system_state is SYSTEM_RUNNING, make sure DO NOT sleep in pr_flush().

---
 kernel/printk/printk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/printk/printk.c +3 -1
index f56fd2e34cc7..53d90278494b 100644
@@ -3545,7 +3545,9 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
 	u64 diff;
 	u64 seq;
 
-	may_sleep = (preemptible() && !in_softirq());
+	may_sleep = (preemptible() &&
+		     !in_softirq() &&
+		     system_state >= SYSTEM_RUNNING);
 
 	seq = prb_next_seq(prb);
 
Signature · 1 line
2.30.2
author reviewer
#2 lore raw

PATCH 2/2 Linux 5.10.56-rt49-rc1

In reply to Steven Rostedt

5.10.56-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: "Steven Rostedt (VMware)" <[email protected]>

---
 localversion-rt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
localversion-rt +1 -1
index 24707986c321..623b4c9cb701 100644
@@ -1 +1 @@
--rt48
+-rt49-rc1
Signature · 1 line
2.30.2