Skip to contentSkip to conversation

net: mdio: Add IPQ MDIO reset related function

PATCH RESEND Superseded Luo Jie 2 participants 5 messages Aug 8, 2021 – Aug 9, 2021

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
author
#2 lore raw

PATCH RESEND 2/2 MDIO: Kconfig: Specify more IPQ chipset supported

In reply to Luo Jie

The IPQ MDIO driver currently supports the chipset IPQ40xx, IPQ807x, IPQ60xx and IPQ50xx.

Add the compatible 'qcom,ipq5018-mdio' because of ethernet LDO dedicated to the IPQ5018 platform.

---
 drivers/net/mdio/Kconfig        | 2 +-
 drivers/net/mdio/mdio-ipq4019.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/net/mdio/Kconfig +1 -1
index a94d34cc7dc1..6da1fcb25847 100644
@@ -172,7 +172,7 @@ config MDIO_IPQ4019
 	depends on COMMON_CLK
 	help
 	  This driver supports the MDIO interface found in Qualcomm
-	  IPQ40xx series Soc-s.
+	  IPQ40xx, IPQ60xx, IPQ807x and IPQ50xx series Soc-s.
 
 config MDIO_IPQ8064
 	tristate "Qualcomm IPQ8064 MDIO interface support"
drivers/net/mdio/mdio-ipq4019.c +1 -0
index 2b6a193f2d67..daaaf1c23f07 100644
@@ -262,6 +262,7 @@ static int ipq4019_mdio_remove(struct platform_device *pdev)
 
 static const struct of_device_id ipq4019_mdio_dt_ids[] = {
 	{ .compatible = "qcom,ipq4019-mdio" },
+	{ .compatible = "qcom,ipq5018-mdio" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ipq4019_mdio_dt_ids);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#1 lore raw

PATCH RESEND 1/2 net: mdio: Add the reset function for IPQ MDIO driver

In reply to Luo Jie

1. configure the MDIO clock source frequency.
2. the LDO resource is needed to configure the ethernet LDO available for CMN_PLL.

---
 drivers/net/mdio/Kconfig        |  1 +
 drivers/net/mdio/mdio-ipq4019.c | 47 +++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
drivers/net/mdio/Kconfig +1 -0
index 99a6c13a11af..a94d34cc7dc1 100644
@@ -169,6 +169,7 @@ config MDIO_OCTEON
 config MDIO_IPQ4019
 	tristate "Qualcomm IPQ4019 MDIO interface support"
 	depends on HAS_IOMEM && OF_MDIO
+	depends on COMMON_CLK
 	help
 	  This driver supports the MDIO interface found in Qualcomm
 	  IPQ40xx series Soc-s.
drivers/net/mdio/mdio-ipq4019.c +47 -0

85 lines not on this page · raw message

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Luo Jie

author
#0 lore raw

cover net: mdio: Add IPQ MDIO reset related function

This patch series add the MDIO reset features, which includes configuring MDIO clock source frequency and indicating CMN_PLL that ethernet LDO has been ready, this ethernet LDO is dedicated in the IPQ5018 platform.

Specify more chipset IPQ40xx, IPQ807x, IPQ60xx and IPQ50xx supported by this MDIO driver.

The PHY reset with GPIO and PHY reset with reset controller are covered by the phylib code, so remove the PHY reset related code from the initial patch series.

Luo Jie (2):
net: mdio: Add the reset function for IPQ MDIO driver
MDIO: Kconfig: Specify more IPQ chipset supported

 drivers/net/mdio/Kconfig        |  3 ++-
 drivers/net/mdio/mdio-ipq4019.c | 48 +++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#3 lore raw
Quoted 11 lines · Luo Jie

This patch series add the MDIO reset features, which includes configuring MDIO clock source frequency and indicating CMN_PLL that ethernet LDO has been ready, this ethernet LDO is dedicated in the IPQ5018 platform.

Specify more chipset IPQ40xx, IPQ807x, IPQ60xx and IPQ50xx supported by this MDIO driver.

The PHY reset with GPIO and PHY reset with reset controller are covered by the phylib code, so remove the PHY reset related code from the initial patch series.

Why did you resend?

To the patchbot: I replied with comments on the first send. Do not merge.

Andrew

author
#4 lore raw
Quoted 12 lines · Andrew Lunn
Quoted 11 lines · Luo Jie

This patch series add the MDIO reset features, which includes configuring MDIO clock source frequency and indicating CMN_PLL that ethernet LDO has been ready, this ethernet LDO is dedicated in the IPQ5018 platform.

Specify more chipset IPQ40xx, IPQ807x, IPQ60xx and IPQ50xx supported by this MDIO driver.

The PHY reset with GPIO and PHY reset with reset controller are covered by the phylib code, so remove the PHY reset related code from the initial patch series.

Quoted 6 lines

Why did you resend?

To the patchbot: I replied with comments on the first send. Do not merge.

Andrew

Hi Andrew,

    i resent the patch series for fixing some format warning.