hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb
PATCH 1/1 hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb
Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it.
--- hw/arm/aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
hw/arm/aspeed.c +2 -1
@@ -959,7 +959,8 @@ static void aspeed_machine_ast2600_evb_class_init(ObjectClass *oc, void *data) amc->fmc_model ="w25q512jv" ; amc->spi_model ="mx66u51235f" ; amc->num_cs =1 ; - amc->macs_mask =ASPEED_MAC1_ON |ASPEED_MAC2_ON |ASPEED_MAC3_ON ; + amc->macs_mask =ASPEED_MAC0_ON |ASPEED_MAC1_ON |ASPEED_MAC2_ON | +ASPEED_MAC3_ON ; amc->i2c_init = ast2600_evb_i2c_init; mc->default_ram_size =1 * GiB; mc->default_cpus = mc->min_cpus = mc->max_cpus =
Signature · 1 line
2.25.1
Quoted 3 lines · Guenter Roeck
Commit
7582591ae7("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it.
Indeed.
I see that commit ba56f464f0c ("ARM: dts: aspeed: ast2600evb: Add MAC0") reintroduced it a while ago. But my A0 doesn't support it. I am missing something.
Joel, why this patch didn't reach the OpenBMC kernel ?
Thanks,
C.
Quoted 21 lines
Signed-off-by Guenter Roeck <[email protected]>--- hw/arm/aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)hw/arm/aspeed.c +2
-1@@ -959,7 +959,8 @@ static void aspeed_machine_ast2600_evb_class_init(ObjectClass *oc, void *data) amc->fmc_model ="w25q512jv" ; amc->spi_model ="mx66u51235f" ; amc->num_cs =1 ; - amc->macs_mask =ASPEED_MAC1_ON |ASPEED_MAC2_ON |ASPEED_MAC3_ON ; + amc->macs_mask =ASPEED_MAC0_ON |ASPEED_MAC1_ON |ASPEED_MAC2_ON | +ASPEED_MAC3_ON ; amc->i2c_init = ast2600_evb_i2c_init; mc->default_ram_size =1 * GiB; mc->default_cpus = mc->min_cpus = mc->max_cpus =
Quoted 6 lines · Cédric Le Goater
Quoted 3 lines · Guenter Roeck
Commit
7582591ae7("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it.
Quoted 7 lines
Indeed.
I see that commit
ba56f464f0c("ARM: dts: aspeed: ast2600evb: Add MAC0") reintroduced it a while ago. But my A0 doesn't support it. I am missing something.Joel, why this patch didn't reach the OpenBMC kernel ?
Because your a0 doesn't support it, so it would break that. That's the only reason.
For this patch,
Quoted 28 lines
Thanks,
C.
Quoted 21 lines
Signed-off-by Guenter Roeck <[email protected]>--- hw/arm/aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)hw/arm/aspeed.c +2
-1@@ -959,7 +959,8 @@ static void aspeed_machine_ast2600_evb_class_init(ObjectClass *oc, void *data) amc->fmc_model ="w25q512jv" ; amc->spi_model ="mx66u51235f" ; amc->num_cs =1 ; - amc->macs_mask =ASPEED_MAC1_ON |ASPEED_MAC2_ON |ASPEED_MAC3_ON ; + amc->macs_mask =ASPEED_MAC0_ON |ASPEED_MAC1_ON |ASPEED_MAC2_ON | +ASPEED_MAC3_ON ; amc->i2c_init = ast2600_evb_i2c_init; mc->default_ram_size =1 * GiB; mc->default_cpus = mc->min_cpus = mc->max_cpus =
Cédric Le Goater
Reviewed-byQuoted 9 lines · Joel Stanley
Quoted 8 lines · Cédric Le Goater
Quoted 3 lines · Guenter Roeck
Commit
7582591ae7("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it.Indeed.
Quoted 8 lines
Quoted 5 lines
I see that commit
ba56f464f0c("ARM: dts: aspeed: ast2600evb: Add MAC0") reintroduced it a while ago. But my A0 doesn't support it. I am missing something.Joel, why this patch didn't reach the OpenBMC kernel ?
Because your a0 doesn't support it, so it would break that. That's the only reason.
OK then.
Quoted 3 lines
For this patch,
Reviewed-by Joel Stanley <[email protected]>
It's queued to aspeed-6.2.
Thanks
C.