Skip to contentSkip to conversation

tests/kms_busy: Limit the execution to single connector

PATCH Superseded Bhanuprakash Modem 2 participants 3 messages Aug 10, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_busy: Limit the execution to single connector

As part of reducing the CI time, we restricted the execution to two pipes (first & last), which also introduced running the tests on all connectors.

	commit 030c28d099a5c6793c92e2b22c8e9abd3d340fdc
	tests/kms_busy: Limit the execution to two pipes

With that change in multi-display configuration, we run the test multiple times on the same pipe with different connectors, which increases the CI time.

This patch will fix the logic to run the tests on a single connector only.

---
 tests/kms_busy.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
tests/kms_busy.c +4 -8
index a60ff6b05..57c11b2ca 100644
@@ -348,9 +348,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 	igt_describe("Test for basic check of KMS ABI with busy framebuffers.");
 	igt_subtest_with_dynamic("basic") { /* just run on the first pipe */
 		enum pipe pipe;
-		igt_output_t *output;
 
-		for_each_pipe_with_valid_output(&display, pipe, output) {
+		for_each_pipe(&display, pipe) {
 			igt_dynamic("flip")
 				test_flip(&display, pipe, false);
 			igt_dynamic("modeset")
@@ -361,11 +360,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 
 	igt_subtest_with_dynamic("basic-hang") {
 		enum pipe pipe;
-		igt_output_t *output;
 		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
-		for_each_pipe_with_valid_output(&display, pipe, output) {
+		for_each_pipe(&display, pipe) {
 			if (!all_pipes && pipe != active_pipes[0] &&
 					  pipe != active_pipes[last_pipe])
 				continue;
@@ -381,11 +379,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 
 	igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") {
 		enum pipe pipe;
-		igt_output_t *output;
 		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
-		for_each_pipe_with_valid_output(&display, pipe, output) {
+		for_each_pipe(&display, pipe) {
 			if (!all_pipes && pipe != active_pipes[0] &&
 					  pipe != active_pipes[last_pipe])
 				continue;
@@ -400,14 +397,13 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
 		igt_subtest_with_dynamic(tests[i].name) {
 			enum pipe pipe;
-			igt_output_t *output;
 			igt_hang_t hang;
 			errno = 0;
 
 			igt_require(display.is_atomic);
 			hang = igt_allow_hang(display.drm_fd, 0, 0);
 
-			for_each_pipe_with_valid_output(&display, pipe, output) {
+			for_each_pipe(&display, pipe) {
 				if (!all_pipes && pipe != active_pipes[0] &&
 						  pipe != active_pipes[last_pipe])
 					continue;
Signature · 1 line
2.32.0
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_busy: Limit the execution to single connector

== Series Details ==

== Series Details ==

Series: tests/kms_busy: Limit the execution to single connector
URL : https://patchwork.freedesktop.org/series/93539/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6164 -> IGTPW_6106
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6106 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6106, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6106:

### IGT changes ###

#### Possible regressions ####

* igt@kms_busy@basic@flip:
- fi-kbl-7567u: NOTRUN -> [CRASH][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-kbl-7567u/igt@kms_busy@[email protected]

* igt@kms_busy@basic@modeset:
- fi-bsw-nick: NOTRUN -> [CRASH][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-bsw-nick/igt@kms_busy@[email protected]
- fi-kbl-guc: NOTRUN -> [CRASH][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-kbl-guc/igt@kms_busy@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_busy@basic@modeset:
- {fi-hsw-gt1}: NOTRUN -> [CRASH][4] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-hsw-gt1/igt@kms_busy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6106 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][5] ([fdo#109315]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-rkl-guc/igt@amdgpu/[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271]) +17 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-kbl-soraka/igt@amdgpu/[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [INCOMPLETE][7] ([i915#3920]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6164/fi-rkl-guc/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/fi-rkl-guc/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#3920]: https://gitlab.freedesktop.org/drm/intel/issues/3920

Participating hosts (36 -> 34)
------------------------------

Missing (2): fi-bsw-cyan fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6164 -> IGTPW_6106

CI-20190529: 20190529
CI_DRM_10462: 1ab8dc433360478c35eba12661f1dd9327588830 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6106: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/index.html
IGT_6164: 7ed112d82c228e755fa773253a25f407bb20965b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6106/index.html

#2 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_busy: Limit the execution to single connector

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_busy: Limit the execution to single connector
URL : https://patchwork.freedesktop.org/series/93539/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/378320 for the overview.

test:ninja-test has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/12648092):

  298/305 assembler test/rndd                     OK       0.02 s 
  299/305 assembler test/rndu                     OK       0.02 s 
  300/305 assembler test/rnde                     OK       0.02 s 
  301/305 assembler test/rnde-intsrc              OK       0.02 s 
  302/305 assembler test/rndz                     OK       0.02 s 
  303/305 assembler test/lzd                      OK       0.02 s 
  304/305 assembler test/not                      OK       0.01 s 
  305/305 assembler test/immediate                OK       0.01 s 

Ok: 280

  Expected Fail:         0
  Fail:                  0
  Unexpected Pass:       0
  Skipped:               0

Timeout: 25

Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt section_end:1628593656:step_script
ERROR: Job failed: execution took longer than 1h0m0s seconds

test:ninja-test-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/12648093):

  298/305 assembler test/rndd                     OK       0.02 s 
  299/305 assembler test/rndu                     OK       0.02 s 
  300/305 assembler test/rnde                     OK       0.02 s 
  301/305 assembler test/rnde-intsrc              OK       0.02 s 
  302/305 assembler test/rndz                     OK       0.02 s 
  303/305 assembler test/lzd                      OK       0.02 s 
  304/305 assembler test/not                      OK       0.02 s 
  305/305 assembler test/immediate                OK       0.01 s 

Ok: 280

  Expected Fail:         0
  Fail:                  0
  Unexpected Pass:       0
  Skipped:               0

Timeout: 25

Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt section_end:1628593672:step_script
ERROR: Job failed: execution took longer than 1h0m0s seconds

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/378320