Skip to contentSkip to conversation

thermal: exynos: Fix an error code in exynos_tmu_probe()

PATCH Applied Dan Carpenter 3 participants 3 messages Aug 10, 2021 – Sep 9, 2021

Subsystems (4)
Kernel janitors Arm Samsung Exynos Thermal Samsung thermal driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 thermal: exynos: Fix an error code in exynos_tmu_probe()

This error path return success but it should propagate the negative error code from devm_clk_get().

Fixes 6c247393cfdd ("thermal: exynos: Add TMU support for Exynos7 SoC")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/thermal/samsung/exynos_tmu.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/samsung/exynos_tmu.c +1 -0
index e9a90bc23b11..f4ab4c5b4b62 100644
@@ -1073,6 +1073,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 		data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");
 		if (IS_ERR(data->sclk)) {
 			dev_err(&pdev->dev, "Failed to get sclk\n");
+			ret = PTR_ERR(data->sclk);
 			goto err_clk;
 		} else {
 			ret = clk_prepare_enable(data->sclk);
Signature · 1 line
2.20.1
merge bot Applied
#2 lore raw

[thermal: thermal/next] thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()

In reply to Dan Carpenter
The following commit has been merged into the thermal/next branch of thermal:

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     02d438f62c05f0d055ceeedf12a2f8796b258c08
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//02d438f62c05f0d055ceeedf12a2f8796b258c08
Author:        Dan Carpenter <[email protected]>
AuthorDate:    Tue, 10 Aug 2021 11:44:13 +03:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Sat, 14 Aug 2021 12:40:35 +02:00

thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()

This error path return success but it should propagate the negative error code from devm_clk_get().

Fixes 6c247393cfdd ("thermal: exynos: Add TMU support for Exynos7 SoC")
Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Daniel Lezcano <[email protected]>
Link https://lore.kernel.org/r/20210810084413.GA23810@kili open here
---
 drivers/thermal/samsung/exynos_tmu.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/samsung/exynos_tmu.c +1 -0
index e9a90bc..f4ab4c5 100644
@@ -1073,6 +1073,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 		data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");
 		if (IS_ERR(data->sclk)) {
 			dev_err(&pdev->dev, "Failed to get sclk\n");
+			ret = PTR_ERR(data->sclk);
 			goto err_clk;
 		} else {
 			ret = clk_prepare_enable(data->sclk);