Skip to contentSkip to conversation

fpga: machxo2-spi: return an error on failure

PATCH In review [email protected] 4 participants 4 messages Aug 10, 2021 – Aug 11, 2021 FPGA manager framework

lore
Share & tools
lore

[email protected]

author reviewer
#0 lore raw

PATCH 1/1 fpga: machxo2-spi: return an error on failure

From: Tom Rix <[email protected]>

Reported problem

	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
	warn: missing error code 'ret'

	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
	warn: missing error code 'ret'

Earlier successes leave 'ret' in a non error state, so these errors are not reported. So set ret to -EINVAL before going to the error handler.

Fixes 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
---
 drivers/fpga/machxo2-spi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/fpga/machxo2-spi.c +4 -1
index 1afb41aa20d71..b4a530a31302f 100644
@@ -225,8 +225,10 @@ static int machxo2_write_init(struct fpga_manager *mgr,
 		goto fail;
 
 	get_status(spi, &status);
-	if (test_bit(FAIL, &status))
+	if (test_bit(FAIL, &status)) {
+		ret = -EINVAL;
 		goto fail;
+	}
 	dump_status_reg(&status);
 
 	spi_message_init(&msg);
@@ -313,6 +315,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
 	dump_status_reg(&status);
 	if (!test_bit(DONE, &status)) {
 		machxo2_cleanup(mgr);
+		ret = -EINVAL;
 		goto fail;
 	}
 
Signature · 1 line
2.26.3
#1 lore raw
Quoted 9 lines · On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reported problem

	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
	warn: missing error code 'ret'

	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
	warn: missing error code 'ret'

What reported this? What does it mean? Where was it reported?

please be specific...

thanks,

greg k-h

#2 lore raw
Quoted 5 lines · Greg KH
Quoted 4 lines · On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reported problem

Quoted 7 lines
Quoted 5 lines
	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
	warn: missing error code 'ret'

	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
	warn: missing error code 'ret'

What reported this? What does it mean? Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so that's on me. I've fixed my report templated to mention Smatch now.

regards,
dan carepenter

maintainer
#3 lore raw
Quoted 12 lines · Dan Carpenter
Quoted 11 lines · Greg KH
Quoted 9 lines · On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reported problem

	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
	warn: missing error code 'ret'

	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
	warn: missing error code 'ret'
Quoted 9 lines
Quoted 1 line

What reported this? What does it mean? Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so that's on me. I've fixed my report templated to mention Smatch now.

regards,
dan carepenter

Applied with slightly reworded commit-message to 'fixes' branch.

Thanks,
Moritz