scsi: qedi: add missing curly braces
Subsystems (3)
PATCH 1/1 scsi: qedi: add missing curly braces
This if statement has missing curly braces so it will always report an error even when the call to ->offload_conn() succeeded.
Fixes 072ae05a044f ("scsi: qedi: Add support for fastpath doorbell recovery")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/qedi/qedi_iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/qedi/qedi_iscsi.c +2 -1
@@ -599,7 +599,7 @@ static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep) } rval = qedi_ops->offload_conn (qedi->cdev, qedi_ep->handle, conn_info); -if (rval) +if (rval) {/* delete doorbell from doorbell recovery mechanism */ rval = qedi_ops->common->db_recovery_del(qedi->cdev, qedi_ep->p_doorbell,
@@ -607,6 +607,7 @@ static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep)QEDI_ERR (&qedi->dbg_ctx,"offload_conn returned %d, ep=%p\n" , rval, qedi_ep); + }kfree (conn_info);return rval;
Signature · 1 line
2.20.1
Hi Dan!
Quoted 2 lines
This if statement has missing curly braces so it will always report an error even when the call to ->offload_conn() succeeded.
Already fixed this up in 9757f8af0442.
Thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering