Skip to contentSkip to conversation

staging: r8188eu: remove cfg80211 residuals

PATCH In review Fabio Aiuto 4 participants 4 messages Aug 12, 2021 – Aug 14, 2021 1 message not in the archive Staging

lore
Share & tools
lore

Fabio Aiuto

author
#0 lore raw

PATCH 1/1 staging: r8188eu: remove cfg80211 residuals

remove cfg80211 implementation residuals:
an headeer file and build condition in Kconfig
file.

Signed-off-by Fabio Aiuto <[email protected]>

---
Dear Greg and Larry,
I thought that cfg80211 had been implemented.
Should we add a TODO file telling developers to
do it in the near future? Is that a condition
for mainlining r8188eu? If so please drop this
patch and sorry for noise.

 drivers/staging/r8188eu/Kconfig               |  2 +-
 .../staging/r8188eu/include/ioctl_cfg80211.h  | 91 -------------------
 drivers/staging/r8188eu/os_dep/rtw_android.c  |  1 -
 3 files changed, 1 insertion(+), 93 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/include/ioctl_cfg80211.h
drivers/staging/r8188eu/Kconfig +1 -1
index dc1719d3f2e4..beb768416ab9 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config R8188EU
 	tristate "Realtek RTL8188EU Wireless LAN NIC driver"
-	depends on WLAN && USB && CFG80211
+	depends on WLAN && USB
 	depends on m
 	select WIRELESS_EXT
 	select WEXT_PRIV
drivers/staging/r8188eu/include/ioctl_cfg80211.h deleted +0 -91

91 lines not on this page · raw message

drivers/staging/r8188eu/os_dep/rtw_android.c +0 -1
index d666feb87a7a..7c5e5c8007e3 100644
@@ -7,7 +7,6 @@
 #include "../include/rtw_android.h"
 #include "../include/osdep_service.h"
 #include "../include/rtw_debug.h"
-#include "../include/ioctl_cfg80211.h"
 #include "../include/rtw_ioctl_set.h"
 
 static const char *android_wifi_cmd_str[ANDROID_WIFI_CMD_MAX] = {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Fabio Aiuto

remove cfg80211 implementation residuals:
an headeer file and build condition in Kconfig file.

Quoted 8 lines
Signed-off-by Fabio Aiuto<[email protected]>

---
Dear Greg and Larry,
I thought that cfg80211 had been implemented. Should we add a TODO file telling developers to do it in the near future? Is that a condition for mainlining r8188eu? If so please drop this patch and sorry for noise.

I thought so too, but something has gone very wrong. Please hold off on this patch until I figure out why cfg80211 is not being used.

Larry

maintainer
#2 lore raw
Quoted 14 lines · Larry Finger
Quoted 4 lines · Fabio Aiuto

remove cfg80211 implementation residuals:
an headeer file and build condition in Kconfig file.

Quoted 8 lines
Signed-off-by Fabio Aiuto<[email protected]>

---
Dear Greg and Larry,
I thought that cfg80211 had been implemented. Should we add a TODO file telling developers to do it in the near future? Is that a condition for mainlining r8188eu? If so please drop this patch and sorry for noise.

Quoted 2 lines

I thought so too, but something has gone very wrong. Please hold off on this patch until I figure out why cfg80211 is not being used.

That's odd, I'll drop this from my queue, we should be using cfg80211

#4 lore raw
In reply to a message not in the archive
Quoted 13 lines · Larry Finger
Quoted 1 line · Greg KH

That's odd, I'll drop this from my queue, we should be using cfg80211

I will be going dark for a while as I add the cfg80211 bits back in.

One piece of good news. I dug out my PowerBook G4 with a PowerPC CPU and tested. Even with all the changes, the driver still works on a big-endian CPU.

Larry

Thanks Larry, and awesome news - a PowerBook G4 - one machine I'm sad I never owned back in the day :-)

Regards,
Phil