Skip to contentSkip to conversation

RDMA/rxe: Remove duplicate umem assignment

PATCH In review Shunsuke Mie 2 participants 3 messages Aug 13, 2021 – Aug 16, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/rxe: Remove duplicate umem assignment

While initialization of rxe_mr, mr->umem is assigned duplicate. Remove the redundant code.

---
 drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_mr.c +0 -1
index 73bbafd32554..6e2e0da2e50d 100644
@@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
 		goto err1;
 	}
 
-	mr->umem = umem;
 	num_buf = ib_umem_num_pages(umem);
 
 	rxe_mr_init(access, mr);
Signature · 1 line
2.25.1
#1 lore raw

Hi,

My same fix[1] has been merged into for-next branch on rdma but it is not merged into mainline for now.

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f

Best Regards,
Xiao Yang

Quoted 20 lines · Shunsuke Mie

While initialization of rxe_mr, mr->umem is assigned duplicate. Remove the redundant code.

---
 drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_mr.c +0 -1
index 73bbafd32554..6e2e0da2e50d 100644
@@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
 		goto err1;
 	}
 
-	mr->umem = umem;
 	num_buf = ib_umem_num_pages(umem);
 
 	rxe_mr_init(access, mr);