Skip to contentSkip to conversation

drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

PATCH Superseded Evan Quan 3 participants 5 messages Aug 13, 2021 – Aug 16, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.

Change-Id I56d4830e6275e20a415808896eecbadfe944070b
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vi.c +6 -1
index fe9a7cc8d9eb..7210f80815b8 100644
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
 	case CHIP_POLARIS11:
 	case CHIP_POLARIS12:
 	case CHIP_TOPAZ:
-		return amdgpu_dpm_is_baco_supported(adev);
+		/* Disable BACO support for the specific polaris12 SKU temporarily */
+		if ((adev->pdev->device == 0x699F) &&
+		    (adev->pdev->revision == 0xC7))
+			return false;
+		else
+			return amdgpu_dpm_is_baco_supported(adev);
 	default:
 		return false;
 	}
Signature · 1 line
2.29.0
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Evan Quan

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.

Change-Id I56d4830e6275e20a415808896eecbadfe944070b
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vi.c +6 -2
index fe9a7cc8d9eb..7210f80815b8 100644
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
        case CHIP_POLARIS11:
        case CHIP_POLARIS12:
        case CHIP_TOPAZ:
-               return amdgpu_dpm_is_baco_supported(adev);
+               /* Disable BACO support for the specific polaris12 SKU temporarily */
+               if ((adev->pdev->device == 0x699F) &&
+                   (adev->pdev->revision == 0xC7))
+                       return false;
+               else
+                       return amdgpu_dpm_is_baco_supported(adev);
        default:
                return false;
        }
--

2.29.0

#2 lore raw
Quoted 8 lines · Alex Deucher
Quoted 4 lines · Evan Quan

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.

Actually it might be worth checking the SSIDs as well assuming this is platform specific.

Alex

Quoted 27 lines
Quoted 27 lines
Change-Id I56d4830e6275e20a415808896eecbadfe944070b
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vi.c +6 -2
index fe9a7cc8d9eb..7210f80815b8 100644
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
        case CHIP_POLARIS11:
        case CHIP_POLARIS12:
        case CHIP_TOPAZ:
-               return amdgpu_dpm_is_baco_supported(adev);
+               /* Disable BACO support for the specific polaris12 SKU temporarily */
+               if ((adev->pdev->device == 0x699F) &&
+                   (adev->pdev->revision == 0xC7))
+                       return false;
+               else
+                       return amdgpu_dpm_is_baco_supported(adev);
        default:
                return false;
        }
--

2.29.0

author
#3 lore raw

[AMD Official Use Only]

Quoted 14 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, August 13, 2021 9:56 PM
To: Quan, Evan <[email protected]>
Cc: amd-gfx list <[email protected]>; Deucher, Alexander <[email protected]>; Chen, Guchun <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

Quoted 3 lines · Alex Deucher
Quoted 8 lines
Quoted 5 lines · Evan Quan
Quoted 4 lines

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.

Actually it might be worth checking the SSIDs as well assuming this is platform specific.

[Quan, Evan] Can you share more how to perform that check? Where to get the SSID?

BR
Evan

Quoted 33 lines

Alex

Quoted 6 lines
Quoted 6 lines
Change-Id I56d4830e6275e20a415808896eecbadfe944070b
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Quoted 6 lines

drivers/gpu/drm/amd/amdgpu/vi.c static bool vi_asic_supports_baco(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8 100644

drivers/gpu/drm/amd/amdgpu/vi.c +0 -0
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct

amdgpu_device *adev)

Quoted 5 lines

drivers/gpu/drm/amd/amdgpu/vi.c static bool vi_asic_supports_baco(struct amdgpu_device *adev)

Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/vi.c +1 -1
        case CHIP_POLARIS11:
        case CHIP_POLARIS12:
        case CHIP_TOPAZ:
-               return amdgpu_dpm_is_baco_supported(adev);
+               /* Disable BACO support for the specific polaris12 SKU

temporarily */

Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/vi.c +5 -1
+               if ((adev->pdev->device == 0x699F) &&
+                   (adev->pdev->revision == 0xC7))
+                       return false;
+               else
+                       return amdgpu_dpm_is_baco_supported(adev);
        default:
                return false;
        }
--

2.29.0

Reviewed-by on v1 1/1
#4 lore raw
In reply to Evan Quan

[Public]

Regards,
Guchun

-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Friday, August 13, 2021 4:10 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Chen, Guchun <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.

Change-Id I56d4830e6275e20a415808896eecbadfe944070b
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vi.c +6 -1
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
 	case CHIP_POLARIS11:
 	case CHIP_POLARIS12:
 	case CHIP_TOPAZ:
-		return amdgpu_dpm_is_baco_supported(adev);
+		/* Disable BACO support for the specific polaris12 SKU temporarily */
+		if ((adev->pdev->device == 0x699F) &&
+		    (adev->pdev->revision == 0xC7))
+			return false;
+		else
+			return amdgpu_dpm_is_baco_supported(adev);
 	default:
 		return false;
 	}

--
2.29.0