Skip to contentSkip to conversation

package/spdlog: bump version to 1.9.2

PATCH In review Michael Nosthoff via buildroot 2 participants 3 messages Aug 13, 2021 – Aug 14, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/spdlog: bump version to 1.9.2

---
 package/spdlog/spdlog.hash | 2 +-
 package/spdlog/spdlog.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/spdlog/spdlog.hash +1 -1
index 5d1ff2f520..02756fc98c 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  944d0bd7c763ac721398dca2bb0f3b5ed16f67cef36810ede5061f35a543b4b8  spdlog-1.8.5.tar.gz
+sha256  6fff9215f5cb81760be4cc16d033526d1080427d236e86d70bb02994f85e3d38  spdlog-1.9.2.tar.gz
 sha256  a7241a379cb98d37788f82c2fc2e484c3ae85dae881fd3406f0637644850926f  LICENSE
package/spdlog/spdlog.mk +1 -1
index ee875ae560..b5dfc0c7b4 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SPDLOG_VERSION = 1.8.5
+SPDLOG_VERSION = 1.9.2
 SPDLOG_SITE = $(call github,gabime,spdlog,v$(SPDLOG_VERSION))
 SPDLOG_LICENSE = MIT
 SPDLOG_LICENSE_FILES = LICENSE
Signature · 6 lines
2.32.0

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw

Hello,

Quoted 30 lines · Michael Nosthoff
---
 package/spdlog/spdlog.hash | 2 +-
 package/spdlog/spdlog.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/spdlog/spdlog.hash +1 -1
index 5d1ff2f520..02756fc98c 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  944d0bd7c763ac721398dca2bb0f3b5ed16f67cef36810ede5061f35a543b4b8  spdlog-1.8.5.tar.gz
+sha256  6fff9215f5cb81760be4cc16d033526d1080427d236e86d70bb02994f85e3d38  spdlog-1.9.2.tar.gz
 sha256  a7241a379cb98d37788f82c2fc2e484c3ae85dae881fd3406f0637644850926f  LICENSE
package/spdlog/spdlog.mk +1 -2
index ee875ae560..b5dfc0c7b4 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SPDLOG_VERSION = 1.8.5
+SPDLOG_VERSION = 1.9.2
 SPDLOG_SITE = $(call github,gabime,spdlog,v$(SPDLOG_VERSION))
 SPDLOG_LICENSE = MIT
 SPDLOG_LICENSE_FILES = LICENSE
--
Quoted 2 lines

2.32.0

This patch seems fine, but it's not really independent because the compilation fails until a newer version of fmt is used. So ideally there should be a small series with both patches.

Asaf.
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

Hi Asaf,

Quoted 26 lines · Asaf Kahlon

Hello,

Quoted 23 lines · Michael Nosthoff
---
  package/spdlog/spdlog.hash | 2 +-
  package/spdlog/spdlog.mk   | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
package/spdlog/spdlog.hash +1 -1
index 5d1ff2f520..02756fc98c 100644
@@ -1,3 +1,3 @@
  # Locally calculated
-sha256  944d0bd7c763ac721398dca2bb0f3b5ed16f67cef36810ede5061f35a543b4b8  spdlog-1.8.5.tar.gz
+sha256  6fff9215f5cb81760be4cc16d033526d1080427d236e86d70bb02994f85e3d38  spdlog-1.9.2.tar.gz
  sha256  a7241a379cb98d37788f82c2fc2e484c3ae85dae881fd3406f0637644850926f  LICENSE
package/spdlog/spdlog.mk +0 -0
index ee875ae560..b5dfc0c7b4 100644
@@ -4,7 +4,7 @@
  #
  ################################################################################
 
Quoted 11 lines
Quoted 8 lines
package/spdlog/spdlog.mk +1 -2
-SPDLOG_VERSION = 1.8.5
+SPDLOG_VERSION = 1.9.2
  SPDLOG_SITE = $(call github,gabime,spdlog,v$(SPDLOG_VERSION))
  SPDLOG_LICENSE = MIT
  SPDLOG_LICENSE_FILES = LICENSE
--

2.32.0

This patch seems fine, but it's not really independent because the compilation fails until a newer version of fmt is used. So ideally there should be a small series with both patches.

That's interesting, 1.9.0 compiles fine with fmt 7.x but 1.9.1 and 1.9.2 fail. I don't think this is intentional as there are #defines in the code to maintain backwards compatibility [0].
I'll report this to spdlog. But for buildroot I guess we're good to go when bumping both packages at once. I'll resubmit as patch series.

Regards,
Michael

[0] https://github.com/gabime/spdlog/blob/v1.x/include/spdlog/common.h#L38

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot