Skip to contentSkip to conversation

auh-config: enable systemd only for glibc

PATCH In review Alexander Kanavin 2 participants 5 messages Aug 14, 2021 – Aug 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 auh-config: enable systemd only for glibc

It is not guaranteed to build or work otherwise, and causes update failures in unrelated recipes when building for musl for instance.

---
 scripts/auh-config/local.conf.append | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/auh-config/local.conf.append +2 -1
index b18590f..417d228 100644
@@ -1,4 +1,5 @@
 
 INHERIT += "buildhistory"
 LICENSE_FLAGS_WHITELIST = "commercial"
-DISTRO_FEATURES_append = ' systemd pam'
+DISTRO_FEATURES_append_libc-glibc = ' systemd'
+DISTRO_FEATURES_append = ' pam'
Signature · 1 line
2.31.1
#1 lore raw

PATCH 2/2 auh-config: adjust to new override syntax

---
 scripts/auh-config/local.conf.append | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/auh-config/local.conf.append +2 -2
index 417d228..25c062b 100644
@@ -1,5 +1,5 @@
 
 INHERIT += "buildhistory"
 LICENSE_FLAGS_WHITELIST = "commercial"
-DISTRO_FEATURES_append_libc-glibc = ' systemd'
-DISTRO_FEATURES_append = ' pam'
+DISTRO_FEATURES:append:libc-glibc = ' systemd'
+DISTRO_FEATURES:append = ' pam'
Signature · 1 line
2.31.1
#2 lore raw
In reply to Alexander Kanavin
Quoted 14 lines · Alexander Kanavin

It is not guaranteed to build or work otherwise, and causes update failures in unrelated recipes when building for musl for instance.

---
  scripts/auh-config/local.conf.append | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
scripts/auh-config/local.conf.append +0 -0
index b18590f..417d228 100644

scripts/auh-config/local.conf.append line 5

Quoted 6 lines
scripts/auh-config/local.conf.append +2 -1
@@ -1,4 +1,5 @@
 
  INHERIT += "buildhistory"
  LICENSE_FLAGS_WHITELIST = "commercial"
-DISTRO_FEATURES_append = ' systemd pam'
+DISTRO_FEATURES_append_libc-glibc = ' systemd'
+DISTRO_FEATURES_append = ' pam'

Please report the problems to mailing list and we can try to help if they do not work with musl. We do support systemd/musl combination and try to keep it working this will limit testing this combination.

Quoted 4 lines
#3 lore raw
Quoted 6 lines · Khem Raj

Please report the problems to mailing list and we can try to help if they do not work with musl. We do support systemd/musl combination and try to keep it working
this will limit testing this combination.

This change is prompted by the recent period where musl patches wouldn't even apply to systemd, which broke half of AUH upgrade attempts.

You need to enable systemd/musl on the autobuilder matrix first, if testing the feature is a concern.

Alex

#4 lore raw
Quoted 4 lines · Alexander Kanavin
Quoted 2 lines · Khem Raj
Quoted 8 lines
Quoted 4 lines

Please report the problems to mailing list and we can try to help if they do not work with musl. We do support systemd/musl combination and try to keep it working
this will limit testing this combination.

This change is prompted by the recent period where musl patches wouldn't even apply to systemd, which broke half of AUH upgrade attempts.

Interesting, outside AB we build extended world on musl and it works well. systemd porters usually port the patches as needed for musl

Quoted 1 line

You need to enable systemd/musl on the autobuilder matrix first, if testing the feature is a concern.

yes, I think thats a fair point, I will bring this up.

Quoted 2 lines

Alex