Skip to contentSkip to conversation

kbuild: Remove -Wno-format-invalid-specifier from clang block

PATCH In review Nathan Chancellor 3 participants 5 messages Aug 16, 2021 – Aug 19, 2021 Kbuild

lore
Share & tools
lore

Nathan Chancellor

author maintainer
#0 lore raw

PATCH 1/3 kbuild: Remove -Wno-format-invalid-specifier from clang block

Turning on -Wformat does not reveal any instances of this warning across several different builds so remove this line to keep the number of disabled warnings as slim as possible.

This has been disabled since commit 61163efae020 ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang"), which does not explain exactly why it was turned off but since it was so long ago in terms of both the kernel and LLVM so it is possible that some bug got fixed along the way.

---
 Makefile | 1 -
 1 file changed, 1 deletion(-)
Makefile +0 -1
index 891866af0787..3900f5824721 100644
@@ -777,7 +777,6 @@ KBUILD_CFLAGS += $(stackp-flags-y)
 
 ifdef CONFIG_CC_IS_CLANG
 KBUILD_CPPFLAGS += -Qunused-arguments
-KBUILD_CFLAGS += -Wno-format-invalid-specifier
 KBUILD_CFLAGS += -Wno-gnu
 # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
 # source of a reference will be _MergedGlobals and not on of the whitelisted names.

base-commit: f12b034afeb3a977bbb1c6584dedc0f3dc666f14

Signature · 1 line
2.33.0.rc2
author maintainer
#1 lore raw

PATCH 2/3 kbuild: Add a comment above -Wno-gnu

Whenever a warning is disabled, it is helpful for future travelers to understand why the warning is disabled and why it is acceptable to do so. Add a comment for -Wno-gnu so that people understand why it is disabled.

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 3900f5824721..07b76274396e 100644
@@ -777,6 +777,7 @@ KBUILD_CFLAGS += $(stackp-flags-y)
 
 ifdef CONFIG_CC_IS_CLANG
 KBUILD_CPPFLAGS += -Qunused-arguments
+# The kernel builds with '-std=gnu89' so use of GNU extensions is acceptable.
 KBUILD_CFLAGS += -Wno-gnu
 # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
 # source of a reference will be _MergedGlobals and not on of the whitelisted names.
Signature · 1 line
2.33.0.rc2
author maintainer
#2 lore raw

PATCH 3/3 kbuild: Shuffle blank line to improve comment meaning

In reply to Nathan Chancellor

-Wunused-but-set-variable and -Wunused-const-variable are both disabled for the same reason but there is a blank line between them and no blank line between -Wno-unused-const-variable and the block.

Shuffle the new line so that it is clear that the comment applied to both flags and the next block is separate from them.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 07b76274396e..7d5007cdfa5c 100644
@@ -794,8 +794,8 @@ endif
 # These warnings generated too much noise in a regular build.
 # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
 KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
-
 KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
+
 ifdef CONFIG_FRAME_POINTER
 KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
 else
Signature · 1 line
2.33.0.rc2
Reviewed-by on v1 1/3
#3 lore raw
In reply to Nathan Chancellor
Quoted 5 lines · Nathan Chancellor

Turning on -Wformat does not reveal any instances of this warning across several different builds so remove this line to keep the number of disabled warnings as slim as possible.

Quoted 7 lines

This has been disabled since commit 61163efae020 ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang"), which does not explain exactly why it was turned off but since it was so long ago in terms of both the kernel and LLVM so it is possible that some bug got fixed along the way.

I ran a few builds with this patch applied and didn't spot any instances of this warning. We can always bring it back if necessary. Thanks for the patch.

Quoted 21 lines
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)
Makefile +0 -1
index 891866af0787..3900f5824721 100644
@@ -777,7 +777,6 @@ KBUILD_CFLAGS += $(stackp-flags-y)
 
 ifdef CONFIG_CC_IS_CLANG
 KBUILD_CPPFLAGS += -Qunused-arguments
-KBUILD_CFLAGS += -Wno-format-invalid-specifier
 KBUILD_CFLAGS += -Wno-gnu
 # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
 # source of a reference will be _MergedGlobals and not on of the whitelisted names.

base-commit: f12b034afeb3a977bbb1c6584dedc0f3dc666f14 --
2.33.0.rc2

Signature · 2 lines
Thanks,
~Nick Desaulniers
#4 lore raw
In reply to Nathan Chancellor
Quoted 5 lines · Nathan Chancellor

Turning on -Wformat does not reveal any instances of this warning across several different builds so remove this line to keep the number of disabled warnings as slim as possible.

Quoted 8 lines

This has been disabled since commit 61163efae020 ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang"), which does not explain exactly why it was turned off but since it was so long ago in terms of both the kernel and LLVM so it is possible that some bug got fixed along the way.

---

All applied to linux-kbuild. Thanks.

Signature · 2 lines
Best Regards
Masahiro Yamada