Skip to contentSkip to conversation

lib-use-pfn_phys-in-devmem_is_allowed.patch removed from -mm tree

merged [email protected] 1 participant 1 message Aug 16, 2021 Stable branch

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: lib: use PFN_PHYS() in devmem_is_allowed()
has been removed from the -mm tree. Its filename was
lib-use-pfn_phys-in-devmem_is_allowed.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Liang Wang <[email protected]>
Subject: lib: use PFN_PHYS() in devmem_is_allowed()

The physical address may exceed 32 bits on 32-bit systems with more than 32 bits of physcial address. Use PFN_PHYS() in devmem_is_allowed(), or the physical address may overflow and be truncated.

We found this bug when mapping a high addresses through devmem tool, when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem is used to map a high address that is not in the iomem address range, an unexpected error indicating no permission is returned.

This bug was initially introduced from v2.6.37, and the function was moved to lib when v5.11.

Fixes 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc Palmer Dabbelt <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Russell King <[email protected]>
Cc Liang Wang <[email protected]>
Cc Xiaoming Ni <[email protected]>
Cc Kefeng Wang <[email protected]>
Cc <[email protected]> [2.6.37+]

---

 lib/devmem_is_allowed.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/devmem_is_allowed.c renamed from lib/devmem_is_allowed.c~lib-use-pfn_phys-in-devmem_is_allowed +1 -1
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)
 {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;

_

Patches currently in -mm which might be from [email protected] are