Skip to contentSkip to conversation

selftests: Use -fno-integrated-as instead of -no-integrated-as

PATCH In review Nathan Chancellor 2 participants 2 messages Aug 16, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: Use -fno-integrated-as instead of -no-integrated-as

-no-integrated-as is considered the legacy flag since clang 3.5 so move -fno-integrated-as in case clang ever decides to remove the legacy flag.

---
 tools/testing/selftests/rseq/Makefile  | 2 +-
 tools/testing/selftests/sched/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/rseq/Makefile +1 -1
index 2af9d39a9716..32f503c13c61 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+ OR MIT
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L$(OUTPUT) -Wl,-rpath=./ \
tools/testing/selftests/sched/Makefile +1 -1
index 10c72f14fea9..d84a19363a62 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/  -Wl,-rpath=./ \

base-commit: 7c60610d476766e128cc4284bb6349732cbd6606

Signature · 1 line
2.33.0.rc2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Nathan Chancellor
(quoted diff) +0 -2
-no-integrated-as is considered the legacy flag since clang 3.5 so move
-fno-integrated-as in case clang ever decides to remove the legacy flag.

Thanks for the patch!

Quoted 36 lines
---
 tools/testing/selftests/rseq/Makefile  | 2 +-
 tools/testing/selftests/sched/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/rseq/Makefile +1 -1
index 2af9d39a9716..32f503c13c61 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+ OR MIT
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L$(OUTPUT) -Wl,-rpath=./ \
tools/testing/selftests/sched/Makefile +1 -1
index 10c72f14fea9..d84a19363a62 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/  -Wl,-rpath=./ \

base-commit: 7c60610d476766e128cc4284bb6349732cbd6606 --
2.33.0.rc2

Signature · 2 lines
Thanks,
~Nick Desaulniers