Skip to contentSkip to conversation

fs/ntfs3: Fix fall-through warnings for Clang

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Aug 18, 2021 – Aug 27, 2021 NTFS3 filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/ntfs3: Fix fall-through warnings for Clang

Fix the following fallthrough warnings:

fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

This helps with the ongoing efforts to globally enable -Wimplicit-fallthrough for Clang.

---
 fs/ntfs3/index.c | 1 +
 fs/ntfs3/inode.c | 1 +
 2 files changed, 2 insertions(+)
fs/ntfs3/index.c +1 -0
index 6aa9540ece47..76eae60b7fce 100644
@@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
 		default:
 			break;
 		}
+		break;
 	default:
 		break;
 	}
fs/ntfs3/inode.c +1 -0
index bf51e294432e..a573c6e98cb8 100644
@@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
 	switch (err) {
 	case 0:
 		drop_nlink(inode);
+		break;
 	case -ENOTEMPTY:
 	case -ENOSPC:
 	case -EROFS:
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Gustavo A. R. Silva

Fix the following fallthrough warnings:

fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

This helps with the ongoing efforts to globally enable -Wimplicit-fallthrough for Clang.

Quoted 30 lines
---
  fs/ntfs3/index.c | 1 +
  fs/ntfs3/inode.c | 1 +
  2 files changed, 2 insertions(+)
fs/ntfs3/index.c +1 -0
index 6aa9540ece47..76eae60b7fce 100644
@@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
  		default:
  			break;
  		}
+		break;
  	default:
  		break;
  	}
fs/ntfs3/inode.c +1 -0
index bf51e294432e..a573c6e98cb8 100644
@@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
  	switch (err) {
  	case 0:
  		drop_nlink(inode);
+		break;
  	case -ENOTEMPTY:
  	case -ENOSPC:
  	case -EROFS:
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 47 lines

From: Gustavo A. R. Silva <[email protected]>
Sent: Thursday, August 19, 2021 1:22 AM
To: Konstantin Komarov <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>; linux- [email protected]
Subject: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang

Fix the following fallthrough warnings:

fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

This helps with the ongoing efforts to globally enable -Wimplicit-fallthrough for Clang.

---
 fs/ntfs3/index.c | 1 +
 fs/ntfs3/inode.c | 1 +
 2 files changed, 2 insertions(+)
fs/ntfs3/index.c +1 -0
index 6aa9540ece47..76eae60b7fce 100644
@@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
 		default:
 			break;
 		}
+		break;
 	default:
 		break;
 	}
fs/ntfs3/inode.c +1 -1
index bf51e294432e..a573c6e98cb8 100644
@@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
 	switch (err) {
 	case 0:
 		drop_nlink(inode);
+		break;
 	case -ENOTEMPTY:
 	case -ENOSPC:
 	case -EROFS:
--
Quoted 1 line

2.27.0

Hi Gustavo, thank you. Picked into ntfs3 tree.

Best regards.