Skip to contentSkip to conversation

staging: r8188eu: use GFP_ATOMIC under spinlock

PATCH New Michael Straube 1 participant 1 message Aug 19, 2021 Staging

lore
Share & tools
lore

Michael Straube

author
#0 lore raw

PATCH 1/1 staging: r8188eu: use GFP_ATOMIC under spinlock

kmalloc() in function update_bcn_wps_ie() is called under a spinlock so the allocation have to be atomic.

-> update_beacon() <- takes a spinlock
-> update_bcn_vendor_spec_ie()

      -> update_bcn_wps_ie()
Fixes 79f712ea994de ("staging: r8188eu: Remove wrappers for kalloc() and kzalloc()")
Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/r8188eu/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_ap.c +1 -1
index 1f3aa0092ef9..41b5668d080b 100644
@@ -1192,7 +1192,7 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 	remainder_ielen = ielen - wps_offset - wps_ielen;
 
 	if (remainder_ielen > 0) {
-		pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_KERNEL);
+		pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_ATOMIC);
 		if (pbackup_remainder_ie)
 			memcpy(pbackup_remainder_ie, premainder_ie, remainder_ielen);
 	}
Signature · 1 line
2.32.0