Skip to contentSkip to conversation

ns16550: Properly gate Exar PCIe UART cards support

PATCH In review Oleksandr Andrushchenko 2 participants 4 messages Aug 20, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ns16550: Properly gate Exar PCIe UART cards support

From: Oleksandr Andrushchenko <[email protected]>

This fixes Arm build which doesn't have ns16550 PCI support.

ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]

  313 |     enable_exar_enhanced_bits(uart);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
Fixes 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support")
---
 xen/drivers/char/ns16550.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/drivers/char/ns16550.c +1 -1
index b777c8711ee0..e2c24082c368 100644
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
     /* Handle the DesignWare 8250 'busy-detect' quirk. */
     handle_dw_usr_busy_quirk(uart);
 
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
     /* Enable Exar "Enhanced function bits" */
     enable_exar_enhanced_bits(uart);
 #endif
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes Arm build which doesn't have ns16550 PCI support.

ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]

  313 |     enable_exar_enhanced_bits(uart);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~

This can't be the full story - both Arm32 and Arm64 build fine for me. In fact I can't find any "select HAS_PCI" outside of x86'es subtree.

Quoted 1 line
Fixes 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support")

IOW this tag is wrong, no matter that I agree that ...

xen/drivers/char/ns16550.c static void ns16550_setup_preirq(struct ns16550 *uart) · line 314

Quoted 11 lines
xen/drivers/char/ns16550.c +1 -1
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
     /* Handle the DesignWare 8250 'busy-detect' quirk. */
     handle_dw_usr_busy_quirk(uart);
 
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
     /* Enable Exar "Enhanced function bits" */
     enable_exar_enhanced_bits(uart);
 #endif

... this change is wanted, but just for consistency for now. If you can supply an improved / accurate description, I'll be happy to commit this with

As an aside - please follow patch submission guidelines: Patches go To the list, with maintainers (and perhaps other relevant folks) on Cc.

Jan

#2 lore raw
Quoted 5 lines · Jan Beulich
Quoted 4 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes Arm build which doesn't have ns16550 PCI support.

Quoted 8 lines
Quoted 3 lines

ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]

   313 |     enable_exar_enhanced_bits(uart);
       |     ^~~~~~~~~~~~~~~~~~~~~~~~~

This can't be the full story - both Arm32 and Arm64 build fine for me. In fact I can't find any "select HAS_PCI" outside of x86'es subtree.

Quoted 1 line
Fixes 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support")

IOW this tag is wrong, no matter that I agree that ...

Ok, the full story is that I am building this with PCI passthrough support on Arm,

so yes, you are obviously correct here and "Fixes" tag does not apply.

I will remove it.

Quoted 15 lines

xen/drivers/char/ns16550.c static void ns16550_setup_preirq(struct ns16550 *uart) · line 314

Quoted 12 lines
xen/drivers/char/ns16550.c +1 -1
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
      /* Handle the DesignWare 8250 'busy-detect' quirk. */
      handle_dw_usr_busy_quirk(uart);
 
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
      /* Enable Exar "Enhanced function bits" */
      enable_exar_enhanced_bits(uart);
  #endif

... this change is wanted, but just for consistency for now. If you can supply an improved / accurate description, I'll be happy to commit this with

Quoted 1 line

I can put the following description:

    ns16550: Properly gate Exar PCIe UART cards support

    Arm is about to get PCI passthrough support which means CONFIG_HAS_PCI will be enabled, so this code will fail as Arm doesn't have ns16550 PCI support:

    ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration] 313 |     enable_exar_enhanced_bits(uart);
          |     ^~~~~~~~~~~~~~~~~~~~~~~~~

    Fix this by gating Exar PCIe UART cards support with the above in mind.

Will this be ok?

Can I keep your rb tag with this description?

Quoted 3 lines

As an aside - please follow patch submission guidelines: Patches go To the list, with maintainers (and perhaps other relevant folks) on Cc.

Sure, sorry about that

Quoted 3 lines

Jan

Thank you,

Oleksandr

#3 lore raw
Quoted 51 lines · Oleksandr Andrushchenko
Quoted 5 lines · Jan Beulich
Quoted 4 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes Arm build which doesn't have ns16550 PCI support.

Quoted 8 lines
Quoted 3 lines

ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]

   313 |     enable_exar_enhanced_bits(uart);
       |     ^~~~~~~~~~~~~~~~~~~~~~~~~

This can't be the full story - both Arm32 and Arm64 build fine for me. In fact I can't find any "select HAS_PCI" outside of x86'es subtree.

Quoted 1 line
Fixes 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support")

IOW this tag is wrong, no matter that I agree that ...

Ok, the full story is that I am building this with PCI passthrough support on Arm,

so yes, you are obviously correct here and "Fixes" tag does not apply.

I will remove it.

Quoted 15 lines

xen/drivers/char/ns16550.c static void ns16550_setup_preirq(struct ns16550 *uart) · line 314

Quoted 12 lines
xen/drivers/char/ns16550.c +1 -1
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
      /* Handle the DesignWare 8250 'busy-detect' quirk. */
      handle_dw_usr_busy_quirk(uart);
 
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
      /* Enable Exar "Enhanced function bits" */
      enable_exar_enhanced_bits(uart);
  #endif

... this change is wanted, but just for consistency for now. If you can supply an improved / accurate description, I'll be happy to commit this with

Quoted 1 line

I can put the following description:

    ns16550: Properly gate Exar PCIe UART cards support

    Arm is about to get PCI passthrough support which means CONFIG_HAS_PCI will be enabled, so this code will fail as Arm doesn't have ns16550 PCI support:

    ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration] 313 |     enable_exar_enhanced_bits(uart);
          |     ^~~~~~~~~~~~~~~~~~~~~~~~~

Quoted 5 lines

    Fix this by gating Exar PCIe UART cards support with the above in mind.

Will this be ok?

Can I keep your rb tag with this description?

No need to resubmit - I've replaced the original description and committed the result.

Jan