Skip to contentSkip to conversation

kbuild: Enable dtc 'pci_device_reg' warning by default

PATCH In review Rob Herring 2 participants 2 messages Aug 20, 2021 – Aug 30, 2021 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: Enable dtc 'pci_device_reg' warning by default

There's only a couple of instances of the 'pci_device_reg' warnings left and they look legit, so let's enable the warning by default.

Cc Heiko Stuebner <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>

---
These are the 2 remaining warnings:

arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi:464.3-52: Warning (pci_device_reg): /pcie@f8000000/pcie@0,0:reg: PCI reg address is not configuration space arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"

---
 scripts/Makefile.lib | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
scripts/Makefile.lib +1 -2
index 10950559b223..c57f14ac6f99 100644
@@ -309,8 +309,7 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \
 	-Wno-alias_paths \
 	-Wno-graph_child_address \
 	-Wno-simple_bus_reg \
-	-Wno-unique_unit_address \
-	-Wno-pci_device_reg
+	-Wno-unique_unit_address
 endif
 
 ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
Signature · 1 line
2.30.2
#1 lore raw
Quoted 7 lines · Rob Herring

There's only a couple of instances of the 'pci_device_reg' warnings left and they look legit, so let's enable the warning by default.

Cc Heiko Stuebner <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>
Quoted 5 lines

---
These are the 2 remaining warnings:

arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi:464.3-52: Warning (pci_device_reg): /pcie@f8000000/pcie@0,0:reg: PCI reg address is not configuration space arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"

Just for the record, bcm2771 issue is being fixed here:
https://lkml.org/lkml/2021/8/30/232

Regards,
Nicolas