Skip to contentSkip to conversation

staging: r8188eu: remove dead code

PATCH New Michael Straube 1 participant 2 messages Aug 22, 2021 Staging

lore
Share & tools
lore

Michael Straube

author
#0 lore raw

PATCH 1/2 staging: r8188eu: remove dead code

if (0) is never true, remove code that is never executed.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/r8188eu/core/rtw_led.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/r8188eu/core/rtw_led.c +1 -4
index 306862aec53a..29c48f1a4fec 100644
@@ -121,10 +121,7 @@ static void SwLedBlink(struct LED_871x *pLed)
 	}
 
 	if (bStopBlinking) {
-		/* if (padapter->pwrctrlpriv.cpwm >= PS_STATE_S2) */
-		if (0) {
-			SwLedOff(padapter, pLed);
-		} else if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
+		if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
 			SwLedOn(padapter, pLed);
 		} else if ((check_fwstate(pmlmepriv, _FW_LINKED)) &&  pLed->bLedOn) {
 			SwLedOff(padapter, pLed);
Signature · 1 line
2.32.0
author
#1 lore raw

PATCH 2/2 staging: r8188eu: remove unnecessary parentheses

Remove unnecessary parentheses to improve readability.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/r8188eu/core/rtw_led.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/r8188eu/core/rtw_led.c +2 -2
index 29c48f1a4fec..cd27873c3e63 100644
@@ -121,9 +121,9 @@ static void SwLedBlink(struct LED_871x *pLed)
 	}
 
 	if (bStopBlinking) {
-		if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
+		if (check_fwstate(pmlmepriv, _FW_LINKED) && !pLed->bLedOn) {
 			SwLedOn(padapter, pLed);
-		} else if ((check_fwstate(pmlmepriv, _FW_LINKED)) &&  pLed->bLedOn) {
+		} else if (check_fwstate(pmlmepriv, _FW_LINKED) && pLed->bLedOn) {
 			SwLedOff(padapter, pLed);
 		}
 		pLed->BlinkTimes = 0;
Signature · 1 line
2.32.0