Skip to contentSkip to conversation

mm: unexport folio_add_lru

PATCH In review Christoph Hellwig 2 participants 3 messages Aug 23, 2021 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: unexport folio_add_lru

Only used in core mm code.

---
 mm/swap.c | 1 -
 1 file changed, 1 deletion(-)
mm/swap.c +0 -1
index 04b678342c020..d88895fcd26f8 100644
@@ -459,7 +459,6 @@ void folio_add_lru(struct folio *folio)
 		__pagevec_lru_add(pvec);
 	local_unlock(&lru_pvecs.lock);
 }
-EXPORT_SYMBOL(folio_add_lru);
 
 /**
  * lru_cache_add_inactive_or_unevictable
Signature · 1 line
2.30.2
#1 lore raw
Quoted 1 line · Christoph Hellwig

Only used in core mm code.

Yes, but that's going to be true of virtually all the folio symbols which are wrapped in folio-compat.c. Perhaps we can give this one a year to see what the CIFS and FUSE folio conversions end up looking like?

#2 lore raw
Quoted 6 lines · Matthew Wilcox
Quoted 1 line · Christoph Hellwig

Only used in core mm code.

Yes, but that's going to be true of virtually all the folio symbols which are wrapped in folio-compat.c. Perhaps we can give this one a year to see what the CIFS and FUSE folio conversions end up looking like?

A year before exporting something random? Yes. CIFS seems to be mostly related to their strange ->readpages which shouldn't exist in this form. Fuse hs some deep mm magic related to replace_page_cache_page, which should probably deal with the LRU as well.