Skip to contentSkip to conversation

platform/x86: ISST: use semi-colons instead of commas

PATCH In review Dan Carpenter 3 participants 3 messages Aug 25, 2021 – Aug 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: ISST: use semi-colons instead of commas

The code works the same either way, but it's better to use semi-colons to separate statements.

---
 drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/x86/intel_speed_select_if/isst_if_common.c +3 -3
index 8a4d52a9028d..c9a85eb2e860 100644
@@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user *argp)
 {
 	struct isst_if_platform_info info;
 
-	info.api_version = ISST_IF_API_VERSION,
-	info.driver_version = ISST_IF_DRIVER_VERSION,
-	info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
+	info.api_version = ISST_IF_API_VERSION;
+	info.driver_version = ISST_IF_DRIVER_VERSION;
+	info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
 	info.mbox_supported = punit_callbacks[ISST_IF_DEV_MBOX].registered;
 	info.mmio_supported = punit_callbacks[ISST_IF_DEV_MMIO].registered;
 
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

The code works the same either way, but it's better to use semi- colons
to separate statements.

Quoted 26 lines

---
 drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c index 8a4d52a9028d..c9a85eb2e860 100644

drivers/platform/x86/intel_speed_select_if/isst_if_common.c +0 -0
@@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user
 *argp)
  {
         struct isst_if_platform_info info;


-       info.api_version = ISST_IF_API_VERSION, -       info.driver_version = ISST_IF_DRIVER_VERSION, -       info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT, +       info.api_version = ISST_IF_API_VERSION; +       info.driver_version = ISST_IF_DRIVER_VERSION; +       info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT; info.mbox_supported = punit_callbacks[ISST_IF_DEV_MBOX].registered; info.mmio_supported = punit_callbacks[ISST_IF_DEV_MMIO].registered;

#2 lore raw
In reply to Dan Carpenter

Hi,

Quoted 4 lines · Dan Carpenter

The code works the same either way, but it's better to use semi-colons to separate statements.

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 22 lines
---
 drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/x86/intel_speed_select_if/isst_if_common.c +3 -3
index 8a4d52a9028d..c9a85eb2e860 100644
@@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user *argp)
 {
 	struct isst_if_platform_info info;
 
-	info.api_version = ISST_IF_API_VERSION,
-	info.driver_version = ISST_IF_DRIVER_VERSION,
-	info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
+	info.api_version = ISST_IF_API_VERSION;
+	info.driver_version = ISST_IF_DRIVER_VERSION;
+	info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
 	info.mbox_supported = punit_callbacks[ISST_IF_DEV_MBOX].registered;
 	info.mmio_supported = punit_callbacks[ISST_IF_DEV_MMIO].registered;