kfence: test: fail fast if disabled at boot
Subsystems (2)
Marco Elver
maintainerPATCH 1/1 kfence: test: fail fast if disabled at boot
Fail kfence_test fast if KFENCE was disabled at boot, instead of each test case trying several seconds to allocate from KFENCE and failing. KUnit will fail all test cases if kunit_suite::init returns an error.
Even if KFENCE was disabled, we still want the test to fail, so that CI systems that parse KUnit output will alert on KFENCE being disabled (accidentally or otherwise).
--- mm/kfence/kfence_test.c | 3 +++ 1 file changed, 3 insertions(+)
mm/kfence/kfence_test.c +3 -0
@@ -800,6 +800,9 @@ static int test_init(struct kunit *test)unsigned long flags;int i; +if (!__kfence_pool) +return -EINVAL ; +spin_lock_irqsave (&observed.lock, flags);for (i =0 ; i <ARRAY_SIZE (observed.lines); i++) observed.lines[i][0 ] ='\0' ;
Signature · 1 line
2.33.0.rc2.250.ged5fa647cd-goog
Quoted 11 lines · Marco Elver
Fail
kfence_testfast if KFENCE was disabled at boot, instead of each test case trying several seconds to allocate from KFENCE and failing. KUnit will fail all test cases ifkunit_suite::initreturns an error.Even if KFENCE was disabled, we still want the test to fail, so that CI systems that parse KUnit output will alert on KFENCE being disabled (accidentally or otherwise).
Reported-by Kefeng Wang <[email protected]>Signed-off-by Marco Elver <[email protected]>
Quoted 21 lines
--- mm/kfence/kfence_test.c | 3 +++ 1 file changed, 3 insertions(+)mm/kfence/kfence_test.c +3
-1@@ -800,6 +800,9 @@ static int test_init(struct kunit *test)unsigned long flags;int i; +if (!__kfence_pool) +return -EINVAL ; +spin_lock_irqsave (&observed.lock, flags);for (i =0 ; i <ARRAY_SIZE (observed.lines); i++) observed.lines[i][0 ] ='\0' ; --2.33.0.rc2.250.ged5fa647cd-goog
Signature · 10 lines
Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
Quoted 10 lines · Marco Elver
Fail
kfence_testfast if KFENCE was disabled at boot, instead of each test case trying several seconds to allocate from KFENCE and failing. KUnit will fail all test cases ifkunit_suite::initreturns an error.Even if KFENCE was disabled, we still want the test to fail, so that CI systems that parse KUnit output will alert on KFENCE being disabled (accidentally or otherwise).
Reported-by Kefeng Wang <[email protected]>Signed-off-by Marco Elver <[email protected]>
Finally find this, it's better, and tested, thanks