CI: github actions: keep "pdb" in artifacts
PATCH 1/1 CI: github actions: keep "pdb" in artifacts
"pdb" files are important for example, for BinSkim analysis. Let us keep them
--- .github/workflows/build.yaml | 1 + 1 file changed, 1 insertion(+)
.github/workflows/build.yaml +1 -0
@@ -227,3 +227,4 @@ jobs: path: | ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.exe ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.dll + ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.pdb
Signature · 1 line
2.29.2.windows.2
Patch is missing SOB line, but I guess this can be fixed by the committer, if needed?
Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158
so that PDBs are indeed stored as artifacts.
Sorry, I missed "signed off by". Please add during commit
Quoted 8 lines · Lev Stipakov
Patch is missing SOB line, but I guess this can be fixed by the committer, if needed?
Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158
so that PDBs are indeed stored as artifacts.Acked-by Lev Stipakov <[email protected]...>
[Openvpn-devel] [PATCH applied] Re: CI: github actions: keep pdb in artifacts
In reply to Ilya ShipitsinSoB added, no further tests.
Your patch has been applied to the master branch.
commit 9da733751ce80b2226ef19923365bd3102cfbd47
Author: Ilya Shipitsin Date: Thu Aug 26 15:02:21 2021 +0500
CI: github actions: keep pdb in artifacts
Signed-off-by: Ilya Shipitsin <[email protected]...>
Acked-by: Lev Stipakov <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg22769.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
Re: [Openvpn-devel] [PATCH applied] Re: CI: github actions: keep pdb in artifacts
Hi,
Quoted 7 lines · Gert Doering
SoB added, no further tests.
Your patch has been applied to the master branch.
commit
9da733751ce80b2226ef19923365bd3102cfbd47Author: Ilya Shipitsin Date: Thu Aug 26 15:02:21 2021 +0500
As requested by Lev, also applied to release/2.5
commit fb3661e6690bc2a32b8a35e2451bf256f3a429ee (HEAD -> release/2.5)
Author: Ilya Shipitsin <[email protected]...> Date: Thu Aug 26 15:02:21 2021 +0500
CI: github actions: keep "pdb" in artifacts
gert
Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]...