drm/amdgpu: show both cmd id and name when psp cmd failed
Subsystems (2)
PATCH 1/1 drm/amdgpu: show both cmd id and name when psp cmd failed
To cover the corner case that people want to know the ID of an UNKNOWN CMD.
Suggested-by John Clements <[email protected]>
Signed-off-by Lang Yu <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -4
@@ -469,10 +469,10 @@ psp_cmd_submit_buf(struct psp_context *psp,*/ if (!skip_unsupport && (psp->cmd_buf_mem->resp.status || !timeout) && !ras_intr) {if (ucode) -DRM_WARN ("failed to load ucode (%s) " , -amdgpu_ucode_name (ucode->ucode_id)); -DRM_WARN ("psp gfx command (%s) failed and response status is (0x%X)\n" , -psp_gfx_cmd_name (psp->cmd_buf_mem->cmd_id), +DRM_WARN ("failed to load ucode %s(0x%X) " , +amdgpu_ucode_name (ucode->ucode_id), ucode->ucode_id); +DRM_WARN ("psp gfx command %s(0x%X) failed and response status is (0x%X)\n" , +psp_gfx_cmd_name (psp->cmd_buf_mem->cmd_id), psp->cmd_buf_mem->cmd_id, psp->cmd_buf_mem->resp.status);if (!timeout) { ret = -EINVAL ;
Signature · 1 line
2.25.1
Reviewed-by Huang Rui <[email protected]>
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Lang Yu
Sent: Friday, August 27, 2021 1:41 PM
To: [email protected]; Clements, John <[email protected]>
Cc: Huang, Ray <[email protected]>; Yu, Lang <[email protected]>
Subject: [PATCH] drm/amdgpu: show both cmd id and name when psp cmd failed
To cover the corner case that people want to know the ID of an UNKNOWN CMD.
Suggested-by John Clements <[email protected]>
Signed-off-by Lang Yu <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -4
@@ -469,10 +469,10 @@ psp_cmd_submit_buf(struct psp_context *psp,*/ if (!skip_unsupport && (psp->cmd_buf_mem->resp.status || !timeout) && !ras_intr) {if (ucode) -DRM_WARN ("failed to load ucode (%s) " , -amdgpu_ucode_name (ucode->ucode_id)); -DRM_WARN ("psp gfx command (%s) failed and response status is (0x%X)\n" , -psp_gfx_cmd_name (psp->cmd_buf_mem->cmd_id), +DRM_WARN ("failed to load ucode %s(0x%X) " , +amdgpu_ucode_name (ucode->ucode_id), ucode->ucode_id); +DRM_WARN ("psp gfx command %s(0x%X) failed and response status is (0x%X)\n" , +psp_gfx_cmd_name (psp->cmd_buf_mem->cmd_id), psp->cmd_buf_mem->cmd_id, psp->cmd_buf_mem->resp.status);if (!timeout) { ret = -EINVAL ;
Signature · 1 line
2.25.1