Skip to contentSkip to conversation

arm: dts: mt7623: add otg nodes for bpi-r2

PATCH Applied Frank Wunderlich 3 participants 3 messages Aug 30, 2021 – Sep 20, 2021

Subsystems (2)
Device tree bindings Arm MediaTek
lore
Share & tools
lore

Frank Wunderlich

author
#0 lore raw

PATCH v2 1/1 arm: dts: mt7623: add otg nodes for bpi-r2

From: Frank Wunderlich <[email protected]>

Add OTG-Nodes for BananaPi-R2

Signed-off-by Frank Wunderlich <[email protected]>

---
patch is based on

"arm: dts: mt7623: add musb device nodes"

https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
---
v2:
rebase on plain 5.14, v1 was based on some not upstreamed work

---
 arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +25 -0
index e96aa0ed1ebd..027c1b0c6a98 100644
@@ -366,6 +366,14 @@ &pcie1_phy {
 	status = "okay";
 };
 
+&pio {
+	musb_pins: musb {
+		pins-musb {
+			pinmux = <MT7623_PIN_237_EXT_SDIO2_FUNC_DRV_VBUS>;
+		};
+	};
+};
+
 &pwm {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pwm_pins_a>;

@@ -396,6 +404,19 @@ &uart2 {
 	status = "okay";
 };
 
+&usb0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&musb_pins>;
+	status = "okay";
+	usb-role-switch;
+
+	connector {
+		compatible = "gpio-usb-b-connector", "usb-b-connector";
+		type = "micro";
+		id-gpios = <&pio 44 GPIO_ACTIVE_HIGH>;
+	};
+};
+
 &usb1 {
 	vusb33-supply = <&reg_3p3v>;
 	vbus-supply = <&reg_5v>;

@@ -408,6 +429,10 @@ &usb2 {
 	status = "okay";
 };
 
+&u2phy1 {
+	status = "okay";
+};
+
 &u3phy1 {
 	status = "okay";
 };
Signature · 1 line
2.25.1
build bot
#1 lore raw
Thank you for the patch! Yet something to improve:

Hi Frank,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.14 next-20210830]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Frank-Wunderlich/arm-dts-mt7623-add-otg-nodes-for-bpi-r2/20210830-230249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7373041f92320da2519f521acf7ee47c22d822e4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Frank-Wunderlich/arm-dts-mt7623-add-otg-nodes-for-bpi-r2/20210830-230249 git checkout 7373041f92320da2519f521acf7ee47c22d822e4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts:407.1-6 Label or path usb0 not found
>> Error: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts:432.1-8 Label or path u2phy1 not found

FATAL ERROR: Syntax error parsing input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

maintainer Applied
#2 lore raw
In reply to Frank Wunderlich
Quoted 5 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add OTG-Nodes for BananaPi-R2

Signed-off-by Frank Wunderlich <[email protected]>

Applied to v5.15-next/dts32

Thanks

Quoted 64 lines

---
patch is based on

"arm: dts: mt7623: add musb device nodes"

https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
---
v2:
rebase on plain 5.14, v1 was based on some not upstreamed work

---
  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 25 +++++++++++++++++++
  1 file changed, 25 insertions(+)
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +25 -0
index e96aa0ed1ebd..027c1b0c6a98 100644
@@ -366,6 +366,14 @@ &pcie1_phy {
  	status = "okay";
  };
 
+&pio {
+	musb_pins: musb {
+		pins-musb {
+			pinmux = <MT7623_PIN_237_EXT_SDIO2_FUNC_DRV_VBUS>;
+		};
+	};
+};
+
  &pwm {
  	pinctrl-names = "default";
  	pinctrl-0 = <&pwm_pins_a>;

@@ -396,6 +404,19 @@ &uart2 {
  	status = "okay";
  };
 
+&usb0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&musb_pins>;
+	status = "okay";
+	usb-role-switch;
+
+	connector {
+		compatible = "gpio-usb-b-connector", "usb-b-connector";
+		type = "micro";
+		id-gpios = <&pio 44 GPIO_ACTIVE_HIGH>;
+	};
+};
+
  &usb1 {
  	vusb33-supply = <&reg_3p3v>;
  	vbus-supply = <&reg_5v>;

@@ -408,6 +429,10 @@ &usb2 {
  	status = "okay";
  };
 
+&u2phy1 {
+	status = "okay";
+};
+
  &u3phy1 {
  	status = "okay";
  };